Add structures to support hot restarting #232
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freya022
added
type: feature
V3
freya022
force-pushed
the
feature/restarter
branch
from
9366ee3 to
c82c3ac
Compare
As it requires adding a dependency
So it doesn't catch the (expected) restart exception
Maybe it works with the restarter, who knows
Will instead make a PR to ClassGraph, overriding class loaders isn't enough
As it has its own hook already
Fixes awaiting termination always waiting until the deadline
This is required for the JDA restart cache module, as it will fire the READY status directly
Calling scheduleShutdownSignal more than once is not great
So it doesn't block the main thread unnecessarily, getting the owners will block until the value is set anyway
freya022
force-pushed
the
feature/restarter
branch
from
c82c3ac to
b4a5694
Compare
When the filesystem changes while an instance is being restarted (slow builds/too short delay), awaiting the new instance allows restarting as soon as the framework is in a state where it can shut down properly
To avoid getting beans while it is closing
Not breaking as this didn't exist earlier
The Spring shutdown listener already doesn't wait for full shutdown
Unfortunately build tool/IDE support sucks for java agents, while the JVM screams at runtime, it can be appeased
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecations
BotCommands#create(<configuration block>)JDAConfiguration.DevToolsshutdownTimeoutinBConfig, which applies to the entire framework's shutdownNew Features
BContext#shutdownBContext#shutdownNowBContext#awaitShutdownSHUTTING_DOWNandSHUTDOWNinBContext.StatusBConfig#enableShutdownHookBConfig#shutdownTimeoutBConfig#argsBRestartConfigBShutdownEventApplicationStartListenerChanges
RequiresDefaultInjectionto the APIisDaemontonamedDefaultScope, defaults tofalse(compatible)To do
ApplicationContexton shutdown