Skip to content

Conversation

@KKRainbow
Copy link
Contributor

No description provided.

Copy link
Contributor

@comzyh comzyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

<el-input type="textarea" :rows=3 v-model="internalData.comments" :disabled="disabledFields.comments"></el-input>
</el-form-item>
<el-form-item label="Auto Restart" class="inline-item">
<el-checkbox v-model="internalData.autoRestart" :disabled="disabledFields.autoRestart" class="inline-item"></el-checkbox>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does inline-item look like?

],
'volumes': volumes,
'restartPolicy': 'OnFailure',
'restartPolicy': 'OnFailure' if bool(auto_restart) else 'Never',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need bool() there?

@xiaoyunwu xiaoyunwu merged commit 60c8b80 into framely:opensource Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants