Skip to content

Conversation

@tcompa
Copy link
Collaborator

@tcompa tcompa commented Jun 6, 2023

Ref #378

@tcompa tcompa linked an issue Jun 6, 2023 that may be closed by this pull request
@jluethi
Copy link
Collaborator

jluethi commented Jun 6, 2023

Can we make the extra fractal-tasks? In that way, we can include a consistent fractal-tasks extra for our package and external packages

@tcompa
Copy link
Collaborator Author

tcompa commented Jun 6, 2023

Can we make the extra fractal-tasks? In that way, we can include a consistent fractal-tasks extra for our package and external packages

Sure. We can have a tasks folder and a fractal_tasks_core[fractal_tasks] extra.

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Coverage report

The coverage rate went from 81.07% to 81.46% ⬆️
The branch rate is 75%.

82.6% of new lines are covered.

Diff Coverage details (click to unfold)

fractal_tasks_core/tasks/create_ome_zarr.py

0% of new lines are covered (82.75% of the complete file).
Missing lines: 433

fractal_tasks_core/tasks/create_ome_zarr_multiplex.py

0% of new lines are covered (86.83% of the complete file).
Missing lines: 484

fractal_tasks_core/tasks/yokogawa_to_ome_zarr.py

0% of new lines are covered (84.25% of the complete file).
Missing lines: 219

fractal_tasks_core/lib_ROI_overlaps.py

100% of new lines are covered (94.97% of the complete file).

fractal_tasks_core/tasks/illumination_correction.py

0% of new lines are covered (76.69% of the complete file).
Missing lines: 274

fractal_tasks_core/tasks/copy_ome_zarr.py

0% of new lines are covered (89.32% of the complete file).
Missing lines: 200

fractal_tasks_core/tasks/maximum_intensity_projection.py

0% of new lines are covered (85.71% of the complete file).
Missing lines: 135

fractal_tasks_core/tasks/cellpose_segmentation.py

0% of new lines are covered (81.87% of the complete file).
Missing lines: 666

fractal_tasks_core/tasks/napari_workflows_wrapper.py

0% of new lines are covered (89.36% of the complete file).
Missing lines: 606

1. Move main functionality into lib_ROI_overlaps.py
2. Update test_unit_parse_yokogawa_metadata.py
3. Move the plotting part into examples/tools/show_FOV_ROIs
@tcompa tcompa merged commit 0925bd6 into main Jun 6, 2023
@tcompa tcompa deleted the 378-making-task-dependencies-optional branch June 6, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move tasks dependencies to fractal-tasks extra

2 participants