feat: added get_blob_by_hash #10987
feat: added get_blob_by_hash #10987
Conversation
Soubhik-10
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
crates/anvil/src/eth/api.rs
Outdated
| pub async fn anvil_get_blob_by_tx_hash( | ||
| &self, | ||
| hash: B256, | ||
| ) -> Result<Option<alloy_consensus::TxEip4844WithSidecar>> { |
There was a problem hiding this comment.
for this we should be able to reuse this logic:
foundry/crates/anvil/src/eth/backend/mem/mod.rs
Lines 2903 to 2909 in d592b3e
we should add a helper fn for this to Backend as well
There was a problem hiding this comment.
i just used the entire fn..not sure..can you please check te new one?
| if let Some(sidecar) = typed_tx.sidecar() { | ||
| for blob in sidecar.sidecar.clone() { | ||
| let versioned_hash = B256::from(blob.to_kzg_versioned_hash()); | ||
| if versioned_hash == hash { | ||
| return Ok(Some(sidecar.clone())); | ||
| } | ||
| } |
There was a problem hiding this comment.
we can simplify this a bit with:
because we want to avoid cloning all sidecars for this since this is a bit expensive
we also want a new helper blob_by_versioned_hash on the sidecar types in alloy, do you want to upstream this?
| /// Handler for RPC call: `anvil_getBlobByTransactionHash` | ||
| pub fn anvil_get_blob_by_tx_hash( |
| let tx = self.mined_transaction_by_hash(hash).unwrap(); | ||
| let typed_tx = TypedTransaction::try_from(tx).unwrap(); | ||
| if let Some(sidecar) = typed_tx.sidecar() { | ||
| return Ok(Some(sidecar.clone())); | ||
| } | ||
| Ok(None) |
There was a problem hiding this comment.
this can fail, so we should handle this gracefully and only return the blobs Vec here
closes #10978