feat(forge fmt): Adds tab support as indent char in fmt #10979
+3,613
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewmeconry
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
|
thank you! looks like it breaks tests for win |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I want to start to contribute and the issue #10754 was marked as a good first issue.
Solution
Adds support for different styles in fmt config. This allows the user to configure whether tabs or spaces should be used (I don't want to start the age-old discussion here).
tab_widthwill be ignored by fmt if the style is set totab.If no style is given in foundry.toml
spacewill be used as default.Coverting block comments from space to tab results in issues where the previous spaces will not be ignored. I couldn't figure out a way to solve this properly but I believe it is a non-issue because most teams won't switch from spaces to tabs that often and fixing some comments is fine from my point of view.
PR Checklist