feat(forge-lint): new LateLintPass + support code snippets
#10846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
pushed a commit
to paradigmxyz/solar
that referenced
this pull request
Jun 25, 2025
i was working on improved lints that would show code diffs, and i realized that despite using `fn highlighted_note`, the `fn flatten_messages` would remove the style. so this PR aims to enhance `fn flatten_messages` to optionally preserve styles while flattening (depending on whether the emitter supports styles or not). i added a new `fn label_with_style()` to try to avoid breaking API changes for solar users, but not sure if may have missed something. @DaniPopes please lmk if the approach looks good or if we should do it differently. PS: `forge-lint` PR in case it is useful foundry-rs/foundry#10846
DaniPopes
reviewed
Jun 25, 2025
BoomchainLabs
approved these changes
Jun 25, 2025
…lints-with-examples
…foundry into rusowsky/lints-with-examples
3 tasks
0xrusowsky
changed the title
LateLintPass + support code snippets
…lints-with-examples
…foundry into rusowsky/lints-with-examples
zerosnacks
reviewed
Jul 15, 2025
zerosnacks
reviewed
Jul 15, 2025
|
lgtm! Pending review from @DaniPopes / @grandizzy |
grandizzy
previously approved these changes
Jul 16, 2025
There was a problem hiding this comment.
lgtm! pending @DaniPopes review, this should also unblock #10980
DaniPopes
reviewed
Jul 16, 2025
| Self::Diff { desc, .. } => *desc, | ||
| Self::Block { desc, .. } => *desc, | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /// Trait for lints that operate directly on the AST. | ||
| /// Its methods mirror `ast::visit::Visit`, with the addition of `LintCotext`. | ||
| pub trait EarlyLintPass<'ast>: Send + Sync { |
There was a problem hiding this comment.
can we move these to early.rs and late.rs
crates/forge/src/cmd/eip712.rs
Outdated
| &sess, | ||
| &self.build, | ||
| None, | ||
| Some(vec![self.target_path].as_ref()), |
…lints-with-examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Motivation
Boost
forge-lintcapabilities by adding 2 new features:Implementation
Linter Architecture
Updated the architecture to a dual-pass system:
Relevant changes:
trait LateLintPassand implemented aLateLintVisitorthat traverses the HIR + runs late lint passes.trait Linterto support both early (AST) and late (HIR) linting phases.earlyorlate.Code Snippet Support
enum Snippetto represent code suggestions:fn emit_with_fix()method toLintContextto emit diagnostics with (formatted) snippets