Skip to content

fix(cast): do not use default overrides if no override arg #10710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2025
Merged

fix(cast): do not use default overrides if no override arg #10710

merged 1 commit into from
Jun 5, 2025

Conversation

grandizzy
Copy link
Collaborator

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@grandizzy grandizzy added T-bug Type: bug C-cast Command: cast labels Jun 5, 2025
@grandizzy grandizzy marked this pull request as ready for review June 5, 2025 08:31
mattsse
mattsse approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, I actually find this easier to read than 5 chained is_none && checks

@grandizzy grandizzy merged commit 8cdf80b into foundry-rs:master Jun 5, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this to Done in Foundry Jun 5, 2025
@grandizzy grandizzy deleted the issue-10705 branch June 5, 2025 08:57
grandizzy added a commit to grandizzy/foundry that referenced this pull request Jun 5, 2025
@grandizzy
fix(cast): do not use default overrides if no override arg (foundry-r…
93a39b1 
…s#10710)
@grandizzy grandizzy mentioned this pull request Jun 5, 2025
Merged
3 tasks
grandizzy added a commit that referenced this pull request Jun 5, 2025
@grandizzy
fix(cast): do not use default overrides if no override arg (v1.2.3 ba…
7a6eb65 
…ckport) (#10713)

* fix(cast): do not use default overrides if no override arg (#10710)

* chore: fix clippy (#10687)

* chore: fix flaky test, bump timeout max rejects, use http provider (#10691)

chore: flaky test, bump timeout max rejects, use http provider

* chore: bump version 1.2.3 (#10712)
@grandizzy grandizzy mentioned this pull request Jun 19, 2025
Merged
3 tasks
@0xgregthedev 0xgregthedev mentioned this pull request Jun 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees
No one assigned
Labels
C-cast Command: cast T-bug Type: bug
Projects
Foundry
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cast call runs into "too many arguments, want at most 2" error
2 participants
@grandizzy @mattsse