Skip to content

Simplify test makefile #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2021
Merged

Simplify test makefile #349

merged 1 commit into from
Apr 9, 2021

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Mar 18, 2021

  • use a single target for all, test and clean
  • makes it easier to add a new subdirectory without having to modify multiple entries

@awvwgk
Simplify test makefile
4358114 
- use a single target for all, test and clean
milancurcic
milancurcic approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I didn't know you could do that.

@milancurcic milancurcic requested a review from jvdp1 March 23, 2021 22:33
jvdp1
jvdp1 approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Less error-prone. Thank you.
From my side, it can be merged!

@awvwgk awvwgk merged commit 928bb28 into fortran-lang:master Apr 9, 2021
@awvwgk awvwgk deleted the test-makefile branch April 9, 2021 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milancurcic milancurcic milancurcic approved these changes

@jvdp1 jvdp1 jvdp1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@awvwgk @milancurcic @jvdp1