-
Notifications
You must be signed in to change notification settings - Fork 195
Added code_coverage support. #1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1039 +/- ##
=========================================
Coverage ? 25.02%
=========================================
Files ? 566
Lines ? 233862
Branches ? 41247
=========================================
Hits ? 58534
Misses ? 175328
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @loiseaujc, however, I have no experience in codecoverage CI setups.
Co-authored-by: Federico Perini <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thank you @loiseaujc
I'll poke @milancurcic and/or @certik, maybe they could help with this? |
Thanks, @loiseaujc. I set the |
version: ${{ matrix.toolchain.version }} | ||
|
||
- name: Setup Fortran Package Manager | ||
uses: fortran-lang/setup-fpm@v5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try with setup-fpm@v7
it should fix the path issue with the installer name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that setup-fpm is called twice in the yml file. It still fails because the second one still points to v5. I think this could be done just once by including the coverage steps after the deployment.
Following the discussion in #937, this PR add code coverage to stdlib using codecov.
Key facts
fpm-deployment.yml
Action with code coverage.Ping: @perazz, @jalvesz, @jvdp1
PS : This is a re-opening of #1024 which was closed when I randomly decided to delete my fork.