Skip to content

Conversation

jalvesz
Copy link
Contributor

@jalvesz jalvesz commented Sep 19, 2025

Opening stand-alone branch to manage joss paper

Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with this format. Overall LGTM. I just have a few suggestions.

Comment on lines +110 to +111
call dense2coo( A , COO )
call coo2csr( COO , CSR )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe for a new feature: call dense2csr(A, CSR)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it could embed the call in just one. Actually I think it might be interesting to have a single interface to automatically detect the input and output matrices such as to internally apply the conversions having a unified API. Haven't thought it through yet though.

Copy link
Member

@jvdp1 jvdp1 Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be something like:

    subroutine dense2sparse_${s1}$(dense,sparse)
        ${t1}$, intent(in) :: dense(:,:)
        class(base_${s1}$_type), intent(out) :: sparse

        select type (sparse)
        type is (COO_${s1}$_type)
        type is (...)

   end subroutine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants