still call "git init" even if fpm.toml exists in backfill #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LKedward
approved these changes
Aug 9, 2021
Member
LKedward
left a comment
LKedward
left a comment
There was a problem hiding this comment.
Thanks for reporting and fixing this! Changes look good to me 👍
awvwgk
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #535 by exiting the routine to create a default fpm.toml manifest if fpm.toml exists
A backfill should not fail with an error, but should just create a more complete
fpmpackage, possibly producing messages along the way depending on what actions are taken.If a backfill that would have created a plain basic fpm.toml file is invoked and the fpm.toml file already exists, the command stops
and therefore does not complete the remaining steps (which is basically currently just a "git init"), so if the package does not already have git initialized it remains so, which is unintended. This change produces an message instead of a failure, allowing the
newsubcommand to continue and to complete the remaining intended actions when the above scenario occurs.