-
Notifications
You must be signed in to change notification settings - Fork 115
Catch execute_command_line errors and print useful messages #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removes fpm backtrace and lists target(s) that failed
awvwgk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a nice improvement, thanks for sharing.
|
Thanks for the review - I think once this and #497 are merged, it would be a good time for a new release ( |
|
I don't see any breaking changes in the CLI or manifest, but just added features and bugfixes, therefore I think it should be |
|
I think the strategy used in Julia's Pkg is not a bad one for versioning in the pre-1.0 stage: https://pkgdocs.julialang.org/v1/compatibility/#compat-pre-1.0-1. Which means in pre-1.0 same minor versions are mostly compatible. |
milancurcic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you! I also thought the next release should be 0.3.0.
|
Thanks for reviewing, I'll now merge. Will put together a separate PR for bumping the version now. |
Adds an
exitstatargument to theexecute_command_linewrapperrunso that failures can be caught and useful messages printed instead of the error stop backtrace.This makes it much easier to determine which source files failed to compile, or which apps/tests failed to run.