Skip to content

Conversation

@LKedward
Copy link
Member

@LKedward LKedward commented Jun 5, 2021

Adds an exitstat argument to the execute_command_line wrapper run so that failures can be caught and useful messages printed instead of the error stop backtrace.
This makes it much easier to determine which source files failed to compile, or which apps/tests failed to run.

@LKedward LKedward linked an issue Jun 5, 2021 that may be closed by this pull request
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice improvement, thanks for sharing.

@LKedward
Copy link
Member Author

Thanks for the review - I think once this and #497 are merged, it would be a good time for a new release (0.3.0).

@awvwgk
Copy link
Member

awvwgk commented Jun 20, 2021

I don't see any breaking changes in the CLI or manifest, but just added features and bugfixes, therefore I think it should be 0.2.1

@LKedward
Copy link
Member Author

Ah yes, am I misinterpreting the discussion in #399 - I'd thought we'd bump minor for any changes during 0.x.x?
Also #412 does break fpm support for packages that have duplicate modules, but I guess that was never officially supported.

@awvwgk
Copy link
Member

awvwgk commented Jun 20, 2021

I think the strategy used in Julia's Pkg is not a bad one for versioning in the pre-1.0 stage: https://pkgdocs.julialang.org/v1/compatibility/#compat-pre-1.0-1. Which means in pre-1.0 same minor versions are mostly compatible.

Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! I also thought the next release should be 0.3.0.

@LKedward
Copy link
Member Author

Thanks for reviewing, I'll now merge. Will put together a separate PR for bumping the version now.

@LKedward LKedward merged commit 0411780 into fortran-lang:master Jun 23, 2021
@LKedward LKedward deleted the backend-grace branch June 23, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't Print Backtrace When Unit Tests Failed

3 participants