Skip to content

Conversation

@awvwgk
Copy link
Member

@awvwgk awvwgk commented Jun 5, 2021

Requires some shuffling of routines to avoid dependency cycles.

Fixes #456

Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! 👍

@ghost
Copy link

ghost commented Jun 6, 2021

Thanks @awvwgk, it works great in my default environment. However, when I switch to the Intel oneAPI environment, remove GCC toolchain from the PATH and run fpm build --compiler ifort, it displays the message "ar is not recognized as an internal or external command, operable program or batch file." After that, the build continues and ends successfully.

C:\Temp\test5>fpm build --compiler ifort
 + mkdir build\dependencies
'ar' is not recognized as an internal or external command, operable program or batch file.
 + mkdir build\ifort_782887A201FCE169\test5
 + ifort -c test\check.f90 /warn:all /check:all …

@awvwgk
Copy link
Member Author

awvwgk commented Jun 6, 2021

@brocolis should be fixed now.

@ghost
Copy link

ghost commented Jun 7, 2021

I've tested the patch in 3 environments, they all work well, thanks @awvwgk 👍

Toolchain available on PATH fpm test --compiler gfortran fpm test --compiler ifort fpm test --compiler ifx
MinGW - -
oneAPI -
oneAPI + MinGW

In environments (1) and (3), fpm executes ar, while in environment (2), fpm executes lib. I think the use of ar in (3) is a bit inconsistent but it does not cause harm so far and can be resolved later.

@ghost
Copy link

ghost commented Jun 7, 2021

In scenario (4), MinGW is found on PATH before Intel oneAPI. It's unusual but it works also.

Toolchain available on PATH fpm test --compiler gfortran fpm test --compiler ifort fpm test --compiler ifx
MinGW - -
oneAPI -
oneAPI + MinGW
MinGW + oneAPI

@LKedward
Copy link
Member

LKedward commented Jun 7, 2021

Thanks for the thorough testing @brocolis! With that I'll now merge

@LKedward LKedward merged commit 2ba3478 into fortran-lang:master Jun 7, 2021
@awvwgk awvwgk deleted the ar-output branch June 7, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fpm displays GNU' ar Copyright notice

2 participants