-
Notifications
You must be signed in to change notification settings - Fork 116
Fix to allow compiling C with Intel CC #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
FPM_C_COMPILER
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍.
I wonder if we should aim towards making build_target a method of a more abstract compiler or linker object to separate the vendor/platform specific build logic from our targets in the long-term. This could be useful for the ar vs link issue as well.
|
Good point, I agree. That seems like a natural direction to take with the targets in the future. |
|
The Rust cc crate converged to having separate |
everythingfunctional
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this do something about flags when compiling C code? I'm fine if we want to add that as a separate PR, just curious.
Also, my installation of oneAPI on Windows doesn't seem to have icc. It works as expected for everything else I tried, (gfortran, ifort, and ifx on Windows, Mac and Linux).
Otherwise, I think this looks good.
I thought that best left for a separate PR, since it will require some discussion about best approaches. |
|
Thanks for the reviews. I'll merge later today if there are no further comments. |
FPM_C_COMPILERgccgfortrangccintel_classiciforticcintel_llvmifxicxintel_flangflangclangibmxlxlfxlcNot addressed in this PR: specifying C compiler flags