feat(install.sh): use wget if curl is missing #429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awvwgk
requested changes
Apr 7, 2021
Member
awvwgk
left a comment
awvwgk
left a comment
There was a problem hiding this comment.
Thanks for sharing.
Please use:
wget -O - $SOURCE_URL > $BOOTSTRAP_DIR/fpm.f90
or
wget $SOURCE_URL -O $BOOTSTRAP_DIR/fpm.f90
to avoid overwriting a file in the user workspace.
Also, please use a fork to propose patches in the future.
added 2 commits
April 7, 2021 10:30
This reverts commit 880d007.
As requested at #429 (review) this avoids overwriting a file in the user workspace.
Contributor
Author
|
@awvwgk the latest commit fulfills your requested change. I think this is ready to merge if the CI tests pass. Shall I do the merge or someone else? |
awvwgk
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior
The
install.shinstallation script fails ifcurlis not present.Behavior enabled by this PR
Use
wgetwhencurlis missing.Use Case
The Lubuntu lightweight Ubuntu distribution has
wgetby default but notcurl.