Local path and remote git dependencies #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds recursive source discovery for local path dependencies
Currently always built.
Now supported with local dev-dependencies
Local dependency paths are relative to the dependent package not the building package.
Member
|
This looks great. Thanks! Let's finish #190 soon, so that we can build upon it. |
There's a bug which causes app-local modules to be added twice if auto-discovery is on and the app is specified in the manifest. This causes the module to be compiled and linked twice. Not detected before because the module contained no symbols. This commit adds an integer symbol to an app-local module to test this bug.
Demonstrates bug in include statement parsing - currently erroneously parsing all statements that begin with 'include'.
Include statements must have a single or double quote immediately following 'include'
Demonstrates bug in include statement parsing - currently erroneously parsing all statements that begin with 'include'.
Include statements must have a single or double quote immediately following 'include'
awvwgk
reviewed
Oct 3, 2020
LKedward
changed the title
awvwgk
approved these changes
Oct 4, 2020
Member
awvwgk
left a comment
awvwgk
left a comment
There was a problem hiding this comment.
Nicely done. I'm glad to see fpm can build itself again.
Co-authored-by: Milan Curcic <[email protected]>
everythingfunctional
approved these changes
Oct 19, 2020
Member
Author
|
Many thanks for the reviews - with three approvals I will merge later today if there are no objections. |
This was referenced Nov 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for local path dependencies and remote git dependencies
Fortran fpm can now build the
hello_fpm,circular_testandcircular_exampleexample packages