Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Clean up #9

Merged
merged 9 commits into from
Oct 28, 2021
Merged

Clean up #9

merged 9 commits into from
Oct 28, 2021

Conversation

realaravinth
Copy link
Member

  • deleted temporary pkg foo
  • restructured codebase
  • job runner is now a class

realaravinth and others added 8 commits October 24, 2021 13:55
@realaravinth
fetch patch
716b980
@realaravinth
clean up
323a2fa
@realaravinth
rust 2018 edition
d3cfa79
@dat-adi @realaravinth
Set up GitHub forge interface
626ec6f 
A simple set up.
Endpoint for `get_issues` is ready.
Endpoint for `create_issue` is underway.
@dat-adi @realaravinth
Testing functionality
54532c2 
Attempting to work with the modules.
Using this as a point to revert back to, if things go wrong.
Implemented the get_repository method, and create_issue.
@dat-adi @realaravinth
Minor fixes to the GitHub implementation
2385e6c
@realaravinth
clean up
d5fd18a
@realaravinth
Merge remote-tracking branch 'origin/master' into foo
8dc3a49
@realaravinth realaravinth requested a review from dat-adi October 25, 2021 08:00
dat-adi
dat-adi reviewed Oct 28, 2021
View reviewed changes
dat-adi
dat-adi reviewed Oct 28, 2021
View reviewed changes
dat-adi
dat-adi suggested changes Oct 28, 2021
View reviewed changes
Copy link
Member

@dat-adi dat-adi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the changes look good, there's like two typos that require a fix, however, it's nothing major.
Please fix those two typos, and I'll merge it.

@dat-adi dat-adi mentioned this pull request Oct 28, 2021
Closed
2 tasks
@realaravinth realaravinth requested a review from dat-adi October 28, 2021 12:42
dat-adi
dat-adi approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@dat-adi dat-adi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been made, and as such can be merged. Approved.

@dat-adi dat-adi merged commit ee205fb into master Oct 28, 2021
@dat-adi dat-adi deleted the foo branch November 1, 2021 11:08
@realaravinth realaravinth mentioned this pull request Apr 14, 2022
Draft
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@dat-adi dat-adi dat-adi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@realaravinth realaravinth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realaravinth @dat-adi