Skip to content

Split non-vc extensions into their own files #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Split non-vc extensions into their own files #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions DEV-Simple.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
73D7676B2190D88B00BD13B6 /* PushNotifications.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 73D7676A2190D88B00BD13B6 /* PushNotifications.framework */; };
73E8ACC72192165E009CE057 /* BrowserViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 73E8ACC62192165E009CE057 /* BrowserViewController.swift */; };
BA7610B322E20FB9004DBB9E /* MarqueeLabel.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = BA7610B222E20FB9004DBB9E /* MarqueeLabel.framework */; };
BD2103FE2345A5B000F1F6FB /* WKWebView+Extensions.swift in Sources */ = {isa = PBXBuildFile; fileRef = BD2103FD2345A5B000F1F6FB /* WKWebView+Extensions.swift */; };
BD2104002345A66B00F1F6FB /* Notification+Extensions.swift in Sources */ = {isa = PBXBuildFile; fileRef = BD2103FF2345A66B00F1F6FB /* Notification+Extensions.swift */; };
BD5C906C21B63CCC000D9F79 /* NetworkReachability.swift in Sources */ = {isa = PBXBuildFile; fileRef = BD5C906B21B63CCC000D9F79 /* NetworkReachability.swift */; };
BD5C906F21B6436F000D9F79 /* NotificationBanner.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = BD5C906E21B6436F000D9F79 /* NotificationBanner.framework */; };
BD5C907321B645CD000D9F79 /* SnapKit.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = BD5C907221B645CD000D9F79 /* SnapKit.framework */; };
Expand Down Expand Up @@ -63,6 +65,8 @@
73D7676A2190D88B00BD13B6 /* PushNotifications.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = PushNotifications.framework; path = Carthage/Build/iOS/PushNotifications.framework; sourceTree = "<group>"; };
73E8ACC62192165E009CE057 /* BrowserViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BrowserViewController.swift; sourceTree = "<group>"; };
BA7610B222E20FB9004DBB9E /* MarqueeLabel.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = MarqueeLabel.framework; path = Carthage/Build/iOS/MarqueeLabel.framework; sourceTree = "<group>"; };
BD2103FD2345A5B000F1F6FB /* WKWebView+Extensions.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "WKWebView+Extensions.swift"; sourceTree = "<group>"; };
BD2103FF2345A66B00F1F6FB /* Notification+Extensions.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "Notification+Extensions.swift"; sourceTree = "<group>"; };
BD5C906B21B63CCC000D9F79 /* NetworkReachability.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = NetworkReachability.swift; sourceTree = "<group>"; };
BD5C906E21B6436F000D9F79 /* NotificationBanner.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = NotificationBanner.framework; path = Carthage/Build/iOS/NotificationBanner.framework; sourceTree = "<group>"; };
BD5C907021B645BE000D9F79 /* MarqueeLabelSwift.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = MarqueeLabelSwift.framework; path = Carthage/Build/iOS/MarqueeLabelSwift.framework; sourceTree = "<group>"; };
Expand Down Expand Up @@ -161,6 +165,7 @@
73D7673A218BA66700BD13B6 /* DEV-Simple */ = {
isa = PBXGroup;
children = (
BD2103FC2345A59900F1F6FB /* Extensions */,
1BA17C8B220C84C3007A8EF5 /* assets */,
1BA17C8A220C84A2007A8EF5 /* core */,
1BA17C89220C848B007A8EF5 /* storyboards */,
Expand Down Expand Up @@ -192,6 +197,15 @@
path = "DEV-SimpleUITests";
sourceTree = "<group>";
};
BD2103FC2345A59900F1F6FB /* Extensions */ = {
isa = PBXGroup;
children = (
BD2103FD2345A5B000F1F6FB /* WKWebView+Extensions.swift */,
BD2103FF2345A66B00F1F6FB /* Notification+Extensions.swift */,
);
path = Extensions;
sourceTree = "<group>";
};
BD5C906D21B6436E000D9F79 /* Frameworks */ = {
isa = PBXGroup;
children = (
Expand Down Expand Up @@ -398,8 +412,10 @@
73D7673E218BA66700BD13B6 /* ViewController.swift in Sources */,
73E8ACC72192165E009CE057 /* BrowserViewController.swift in Sources */,
73D7673C218BA66700BD13B6 /* AppDelegate.swift in Sources */,
BD2104002345A66B00F1F6FB /* Notification+Extensions.swift in Sources */,
1B032B1821E409FE00A2108A /* Globals.swift in Sources */,
BD5C906C21B63CCC000D9F79 /* NetworkReachability.swift in Sources */,
BD2103FE2345A5B000F1F6FB /* WKWebView+Extensions.swift in Sources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down
15 changes: 15 additions & 0 deletions DEV-Simple/Extensions/Notification+Extensions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
//
// Notification+Extensions.swift
// DEV-Simple
//
// Created by Daniel Chick on 10/2/19.
// Copyright © 2019 DEV. All rights reserved.
//

import Foundation

extension Notification.Name {
static let didReceiveData = Notification.Name("didReceiveData")
static let didCompleteTask = Notification.Name("didCompleteTask")
static let completedLengthyDownload = Notification.Name("completedLengthyDownload")
}
18 changes: 18 additions & 0 deletions DEV-Simple/Extensions/WKWebView+Extensions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
//
// WKWebView+Extensions.swift
// DEV-Simple
//
// Created by Daniel Chick on 10/2/19.
// Copyright © 2019 DEV. All rights reserved.
//

import WebKit

extension WKWebView {
func load(_ urlString: String) {
if let url = URL(string: urlString) {
let request = URLRequest(url: url)
load(request)
}
}
}
15 changes: 0 additions & 15 deletions DEV-Simple/views/ViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,6 @@ import UserNotifications
import PushNotifications
import NotificationBanner

extension Notification.Name {
static let didReceiveData = Notification.Name("didReceiveData")
static let didCompleteTask = Notification.Name("didCompleteTask")
static let completedLengthyDownload = Notification.Name("completedLengthyDownload")
}

struct UserData: Codable {
enum CodingKeys: String, CodingKey {
case userID = "id"
Expand Down Expand Up @@ -398,12 +392,3 @@ extension ViewController: WKScriptMessageHandler {
}
}
}

extension WKWebView {
func load(_ urlString: String) {
if let url = URL(string: urlString) {
let request = URLRequest(url: url)
load(request)
}
}
}