Add Native Refresh Button To Navigation Bar #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Aug 26, 2019
Contributor
Author
|
@benhalpern Just checking in! :) It looks like my PR needs to be reviewed. What questions or feedback do you have on my PR, or does someone else need to review it or ... ? |
benhalpern
approved these changes
Nov 6, 2019
Contributor
benhalpern
left a comment
benhalpern
left a comment
There was a problem hiding this comment.
Sorry for the long long delay. But this is great and being merged now. 🙂
Contributor
Author
|
No worries, @benhalpern ! Glad I could help, and let me know if you have any more questions for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address issue #164
where the only way to refresh the current page is to do a pull-refresh.
We are giving users an additional way to refresh the page by adding a native refresh button to the navigation bar as shown here:
I only tested this feature manually, but if you have any feedback on whether or how I should add a unit test or UI test, I welcome that. Thanks!