Skip to content

Conversation

nosilleg
Copy link
Contributor

@nosilleg nosilleg commented Mar 9, 2016

This change prevents visible from being populated on render after entryText has been cleared.

Fixes #162

@fmoo
Copy link
Owner

fmoo commented Mar 9, 2016

Just to confirm, you re-ran the test suite and everything still passes?

Also, is there a quick test case you can add to confirm the behavior?

@nosilleg
Copy link
Contributor Author

nosilleg commented Mar 9, 2016

All 69 tests are passing.

Every case is a test case as long as you can press tab twice faster than the component re-renders... 😄

Seriously though, I don't have a test case ready. Hopefully the "stack trace" in the issue explains the situation. It's only possible to get two tokens generated from this because the next render will pass the "old" entryText value of "", which is the same as the expected value at that point.

The basic premise of the change is that the available options should be based solely on the upcoming state, not a mixture of the current and next state.

fmoo added a commit that referenced this pull request Mar 9, 2016
Fix cWRP to look at new values
@fmoo fmoo merged commit ed49656 into fmoo:master Mar 9, 2016
@fmoo
Copy link
Owner

fmoo commented Mar 9, 2016

Merged, tagged, and 1.1.6 pushed to npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants