Skip to content

Commit c77c604

Browse files
author
Renzo Olivares
committed
Merge remote-tracking branch 'upstream/master' into tap_drag_gestures
2 parents ba4e195 + 253e3c0 commit c77c604

File tree

99 files changed

+2203
-854
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

99 files changed

+2203
-854
lines changed

.ci.yaml

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,17 @@ platform_properties:
2929
os: Ubuntu
3030
cores: "8"
3131
device_type: none
32+
linux_build_test:
33+
properties:
34+
dependencies: >-
35+
[
36+
{"dependency": "android_sdk", "version": "version:33v6"},
37+
{"dependency": "open_jdk", "version": "version:11"},
38+
{"dependency": "curl", "version": "version:7.64.0"}
39+
]
40+
os: Ubuntu
41+
cores: "8"
42+
device_type: none
3243
linux_android:
3344
properties:
3445
dependencies: >-
@@ -1922,14 +1933,16 @@ targets:
19221933
["devicelab", "android", "linux"]
19231934
task_name: new_gallery__transition_perf
19241935

1925-
- name: Linux_android flutter_gallery__transition_perf
1926-
recipe: devicelab/devicelab_drone
1936+
- name: Linux_build_test flutter_gallery__transition_perf
1937+
recipe: devicelab/devicelab_drone_build_test
1938+
bringup: true # New target https://github.com/flutter/flutter/issues/103542
19271939
presubmit: false
19281940
timeout: 60
19291941
properties:
19301942
tags: >
19311943
["devicelab", "android", "linux"]
19321944
task_name: flutter_gallery__transition_perf
1945+
artifact: gallery_app_profile
19331946

19341947
- name: Linux_android flutter_gallery__transition_perf_e2e
19351948
recipe: devicelab/devicelab_drone
@@ -2417,7 +2430,8 @@ targets:
24172430
properties:
24182431
dependencies: >-
24192432
[
2420-
{"dependency": "xcode", "version": "13f17a"}
2433+
{"dependency": "xcode", "version": "13f17a"},
2434+
{"dependency": "gems", "version": "v3.3.14"}
24212435
]
24222436
tags: >
24232437
["devicelab", "hostonly"]
@@ -2466,6 +2480,7 @@ targets:
24662480
- .ci.yaml
24672481

24682482
- name: Mac flutter_gallery_macos__compile
2483+
bringup: true # New target https://github.com/flutter/flutter/issues/109633
24692484
recipe: devicelab/devicelab_drone
24702485
timeout: 60
24712486
properties:

.gitignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,10 @@ unlinked_spec.ds
107107
**/macos/Flutter/ephemeral
108108
**/xcuserdata/
109109

110+
# Windows
111+
**/windows/flutter/generated_plugin_registrant.cc
112+
**/windows/flutter/generated_plugin_registrant.h
113+
110114
# Coverage
111115
coverage/
112116

bin/internal/engine.version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
ac1eb78a63c72bc6c77748a730c482ff5df55499
1+
9f306a6ca740ea8f9538587c74d3e39d6e3fd684

bin/internal/flutter_plugins.version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
20bb8653be9ed5e95c6a559e4a466dcded409500
1+
c08e447f989c154c9f111298014e090da6cc4c41

bin/internal/fuchsia-linux.version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
YA1UNiP5OSCiW_xtPZqMKQAxrV7bzQY0jdylqfrKkYYC
1+
NwG1XTWHxB9R3XcU5RnI7-xe864ILf4QRkQAWYNeFy4C

bin/internal/fuchsia-mac.version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
tkgkEsRLKXHmBfwZ5Cah6yQvqr5z0qzLiNJV9oRp2FkC
1+
4GZkuoQmvVanO84uAX2O1xjoD2W4NUVRi1aGpqkhXkQC

dev/benchmarks/complex_layout/lib/src/app.dart

Lines changed: 21 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,26 @@ class ComplexLayout extends StatefulWidget {
9090
class ComplexLayoutState extends State<ComplexLayout> {
9191
@override
9292
Widget build(BuildContext context) {
93-
print(widget.badScroll);
93+
Widget body = ListView.builder(
94+
key: const Key('complex-scroll'), // this key is used by the driver test
95+
controller: ScrollController(), // So that the scroll offset can be tracked
96+
itemCount: widget.badScroll ? 500 : null,
97+
shrinkWrap: widget.badScroll,
98+
itemBuilder: (BuildContext context, int index) {
99+
if (index.isEven) {
100+
return FancyImageItem(index, key: PageStorageKey<int>(index));
101+
} else {
102+
return FancyGalleryItem(index, key: PageStorageKey<int>(index));
103+
}
104+
},
105+
);
106+
if (widget.badScroll) {
107+
body = ListView(
108+
key: const Key('complex-scroll-bad'),
109+
children: <Widget>[body],
110+
);
111+
}
112+
94113
return Scaffold(
95114
appBar: AppBar(
96115
title: const Text('Advanced Layout'),
@@ -107,21 +126,7 @@ class ComplexLayoutState extends State<ComplexLayout> {
107126
),
108127
body: Column(
109128
children: <Widget>[
110-
Expanded(
111-
child: ListView.builder(
112-
key: const Key('complex-scroll'), // this key is used by the driver test
113-
controller: ScrollController(), // So that the scroll offset can be tracked
114-
itemCount: widget.badScroll ? 500 : null,
115-
shrinkWrap: widget.badScroll,
116-
itemBuilder: (BuildContext context, int index) {
117-
if (index.isEven) {
118-
return FancyImageItem(index, key: PageStorageKey<int>(index));
119-
} else {
120-
return FancyGalleryItem(index, key: PageStorageKey<int>(index));
121-
}
122-
},
123-
),
124-
),
129+
Expanded(child: body),
125130
const BottomBar(),
126131
],
127132
),

dev/benchmarks/complex_layout/test_driver/scroll_perf_bad_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ void main() {
5353
}
5454

5555
test('complex_layout_scroll_perf', () async {
56-
await testScrollPerf('complex-scroll', 'complex_layout_scroll_perf');
56+
await testScrollPerf('complex-scroll-bad', 'complex_layout_scroll_perf');
5757
}, timeout: Timeout.none);
5858
});
5959
}

dev/ci/docker_linux/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
# Last manual update 2021-09-24 (changing this comment will re-build image)
1414

15-
FROM debian@sha256:68c1f6bae105595d2ebec1589d9d476ba2939fdb11eaba1daec4ea826635ce75
15+
FROM ubuntu:bionic@sha256:e4771b7160543c6e43968b4e9795be9ddcad9d573edd7cd7aebd3ce61326fc7a
1616
MAINTAINER Flutter Developers <[email protected]>
1717

1818
RUN apt-get update -y && \

dev/conductor/core/lib/src/start.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,13 +134,13 @@ class StartCommand extends Command<void> {
134134
platform.environment,
135135
)!;
136136
final String frameworkMirror =
137-
'https://github.com/$githubUsername/flutter.git';
137+
'git@github.com:$githubUsername/flutter.git';
138138
final String engineUpstream = getValueFromEnvOrArgs(
139139
kEngineUpstreamOption,
140140
argumentResults,
141141
platform.environment,
142142
)!;
143-
final String engineMirror = 'https://github.com/$githubUsername/engine.git';
143+
final String engineMirror = 'git@github.com:$githubUsername/engine.git';
144144
final String candidateBranch = getValueFromEnvOrArgs(
145145
kCandidateOption,
146146
argumentResults,

0 commit comments

Comments
 (0)