@@ -195,14 +195,7 @@ void main() {
195
195
await tester.pump ();
196
196
expect (singleTapUpCount, 0 );
197
197
expect (tapCount, 1 );
198
-
199
- // TODO(Renzo-Olivares): Since Taps and Long Presses/ and Taps and Drags are now bundled
200
- // how should the cancel callback be handled.
201
- // 1. Should it be handled on tap cancel?
202
- // 2. On Drag/Longpress cancel?
203
- // 3. Both.
204
198
expect (singleTapCancelCount, 1 );
205
-
206
199
expect (doubleTapDownCount, 0 );
207
200
expect (singleLongTapStartCount, 0 );
208
201
});
@@ -387,7 +380,6 @@ void main() {
387
380
);
388
381
await tester.pump ();
389
382
await gesture.moveBy (const Offset (210.0 , 200.0 ));
390
- await gesture.moveBy (const Offset (210.0 , 210.0 ));
391
383
await tester.pump ();
392
384
await gesture.up ();
393
385
await tester.pumpAndSettle ();
@@ -411,13 +403,6 @@ void main() {
411
403
);
412
404
await tester.pump ();
413
405
await gesture.moveBy (const Offset (210.0 , 200.0 ));
414
-
415
- // TODO(Renzo-Olivares): The previous DragGestureRecognizer fired two PointerMoveEvents at the start of
416
- // a drag when DragStartBehavior was set to DragStartBehavior.down. Currently the new TapAndDragGestureRecognizer
417
- // fires one PointerMoveEvent per PointerEvent that reaches handleEvent. So where before only one
418
- // gesture.moveBy was necessary to trigger drag update, now two are necessary. Is there any upside/downside to either
419
- // approach?
420
- await gesture.moveBy (const Offset (210.0 , 210.0 ));
421
406
await tester.pump ();
422
407
await gesture.up ();
423
408
await tester.pumpAndSettle ();
@@ -443,12 +428,6 @@ void main() {
443
428
);
444
429
await tester.pump (const Duration (seconds: 2 ));
445
430
await gesture.moveBy (const Offset (210.0 , 200.0 ));
446
- // TODO(Renzo-Olivares): The previous DragGestureRecognizer fired two PointerMoveEvents at the start of
447
- // a drag when DragStartBehavior was set to DragStartBehavior.down. Currently the new TapAndDragGestureRecognizer
448
- // fires one PointerMoveEvent per PointerEvent that reaches handleEvent. So where before only one
449
- // gesture.moveBy was necessary to trigger drag update, now two are necessary. Is there any upside/downside to either
450
- // approach?
451
- await gesture.moveBy (const Offset (210.0 , 210.0 ));
452
431
await tester.pump ();
453
432
await gesture.up ();
454
433
await tester.pumpAndSettle ();
0 commit comments