Skip to content

Commit ba4e195

Browse files
author
Renzo Olivares
committed
remove unecessary changes to tests
1 parent 0a008f0 commit ba4e195

File tree

1 file changed

+0
-21
lines changed

1 file changed

+0
-21
lines changed

packages/flutter/test/widgets/text_selection_test.dart

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -195,14 +195,7 @@ void main() {
195195
await tester.pump();
196196
expect(singleTapUpCount, 0);
197197
expect(tapCount, 1);
198-
199-
// TODO(Renzo-Olivares): Since Taps and Long Presses/ and Taps and Drags are now bundled
200-
// how should the cancel callback be handled.
201-
// 1. Should it be handled on tap cancel?
202-
// 2. On Drag/Longpress cancel?
203-
// 3. Both.
204198
expect(singleTapCancelCount, 1);
205-
206199
expect(doubleTapDownCount, 0);
207200
expect(singleLongTapStartCount, 0);
208201
});
@@ -387,7 +380,6 @@ void main() {
387380
);
388381
await tester.pump();
389382
await gesture.moveBy(const Offset(210.0, 200.0));
390-
await gesture.moveBy(const Offset(210.0, 210.0));
391383
await tester.pump();
392384
await gesture.up();
393385
await tester.pumpAndSettle();
@@ -411,13 +403,6 @@ void main() {
411403
);
412404
await tester.pump();
413405
await gesture.moveBy(const Offset(210.0, 200.0));
414-
415-
// TODO(Renzo-Olivares): The previous DragGestureRecognizer fired two PointerMoveEvents at the start of
416-
// a drag when DragStartBehavior was set to DragStartBehavior.down. Currently the new TapAndDragGestureRecognizer
417-
// fires one PointerMoveEvent per PointerEvent that reaches handleEvent. So where before only one
418-
// gesture.moveBy was necessary to trigger drag update, now two are necessary. Is there any upside/downside to either
419-
// approach?
420-
await gesture.moveBy(const Offset(210.0, 210.0));
421406
await tester.pump();
422407
await gesture.up();
423408
await tester.pumpAndSettle();
@@ -443,12 +428,6 @@ void main() {
443428
);
444429
await tester.pump(const Duration(seconds: 2));
445430
await gesture.moveBy(const Offset(210.0, 200.0));
446-
// TODO(Renzo-Olivares): The previous DragGestureRecognizer fired two PointerMoveEvents at the start of
447-
// a drag when DragStartBehavior was set to DragStartBehavior.down. Currently the new TapAndDragGestureRecognizer
448-
// fires one PointerMoveEvent per PointerEvent that reaches handleEvent. So where before only one
449-
// gesture.moveBy was necessary to trigger drag update, now two are necessary. Is there any upside/downside to either
450-
// approach?
451-
await gesture.moveBy(const Offset(210.0, 210.0));
452431
await tester.pump();
453432
await gesture.up();
454433
await tester.pumpAndSettle();

0 commit comments

Comments
 (0)