Skip to content

Version 4.0.0 #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 9, 2019
Merged

Conversation

brianegan
Copy link
Collaborator

Attempts to address all feedback from the pub.dev site and from the Flutter GDE group. Note: I've added the ability to run tests and collect coverage via travis and codecov, but I do not have the ability to enable those services for this repo, so I'd need your help to do so!

  • dispatch returns the provided action [fixes Proposal - have dispatch return original action #26]
  • Removed Dart 1.x support (required to use Pedantic package, and it's probably a good time!)
  • Enforce Pedantic package lint rules
  • Enforce public_member_api_docs lint rule and add docs to missing parts
  • Update travis.yml with support for dartfmt, analysis, and code coverage
  • Pub.dev updates
    • Longer description
    • https for package url
    • update example folder to include README

@brianegan
Copy link
Collaborator Author

Oops, looks like travis is actually running -- would still need some kind of code coverage provider!

@codecov-io
Copy link

codecov-io commented Nov 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@cb629ce). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #53   +/-   ##
========================================
  Coverage          ?   92.1%           
========================================
  Files             ?       2           
  Lines             ?      38           
  Branches          ?       0           
========================================
  Hits              ?      35           
  Misses            ?       3           
  Partials          ?       0
Impacted Files Coverage Δ
lib/src/utils.dart 100% <ø> (ø)
lib/src/store.dart 88% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb629ce...1162d0c. Read the comment docs.

@brianegan
Copy link
Collaborator Author

brianegan commented Nov 7, 2019

And just as I say that, we have codecov enabled. My bad! This is great :) I'll add the coverage badge to the README.

@brianegan brianegan requested a review from johnpryan November 7, 2019 17:21
Copy link
Collaborator

@johnpryan johnpryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Brian!

@@ -0,0 +1,9 @@
import 'middleware_test.dart' as middleware_test;
import 'store_test.dart' as store_test;
import 'utils_test.dart' as utils_test;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option for code coverage is to use package:coverage

Copy link
Collaborator Author

@brianegan brianegan Nov 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm -- this PR makes use of package:coverage to collect the coverage, but I created this file since I wanted collect coverage from all tests in one shot.

Does the coverage package have a way to do the same thing as "pub run test", which automatically runs all tests?

@brianegan brianegan merged commit a2bbdac into fluttercommunity:master Nov 9, 2019
@brianegan brianegan deleted the flutter-team-fixes branch November 9, 2019 12:10
@tudor07
Copy link

tudor07 commented Nov 11, 2019

Great work guys, really excited for this release. I like using Redux in Flutter a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal - have dispatch return original action
4 participants