-
Notifications
You must be signed in to change notification settings - Fork 58
Version 4.0.0 #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 4.0.0 #53
Conversation
Oops, looks like travis is actually running -- would still need some kind of code coverage provider! |
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
========================================
Coverage ? 92.1%
========================================
Files ? 2
Lines ? 38
Branches ? 0
========================================
Hits ? 35
Misses ? 3
Partials ? 0
Continue to review full report at Codecov.
|
And just as I say that, we have codecov enabled. My bad! This is great :) I'll add the coverage badge to the README. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks Brian!
@@ -0,0 +1,9 @@ | |||
import 'middleware_test.dart' as middleware_test; | |||
import 'store_test.dart' as store_test; | |||
import 'utils_test.dart' as utils_test; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another option for code coverage is to use package:coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hrm -- this PR makes use of package:coverage
to collect the coverage, but I created this file since I wanted collect coverage from all tests in one shot.
Does the coverage package have a way to do the same thing as "pub run test", which automatically runs all tests?
Great work guys, really excited for this release. I like using Redux in Flutter a lot. |
Attempts to address all feedback from the pub.dev site and from the Flutter GDE group. Note: I've added the ability to run tests and collect coverage via
travis
andcodecov
, but I do not have the ability to enable those services for this repo, so I'd need your help to do so!dispatch
returns the provided action [fixes Proposal - have dispatch return original action #26]public_member_api_docs
lint rule and add docs to missing partstravis.yml
with support for dartfmt, analysis, and code coverage