Skip to content

Conversation

elias8
Copy link
Member

@elias8 elias8 commented Jan 15, 2022

Description

In Android, the Intent class has two different methods to put an array and array list values to the intent. And in the previous implementation, we only use one of them, which is used to put array list values to the intent. And since dart List type is mapped to ArrayList in java, it limits users to pass array types to the Intent.

So this PR fixes that by introducing a new argument to the AndroidIntent class to pass array arguments to the intent as I have mentioned here.

Related Issues

Fixes flutter/flutter#54362 and closes #75

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated the version in pubspec.yaml and CHANGELOG.md.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@elias8 elias8 force-pushed the fix/android_intent_plus branch from 889db83 to 64b2df1 Compare January 15, 2022 01:02
@elias8 elias8 removed the request for review from miquelbeltran January 16, 2022 16:10
Copy link
Collaborator

@vbuberen vbuberen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Let's update changelogs and version as well.
I believe we should bump minor version for such change.

Copy link
Collaborator

@vbuberen vbuberen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻
Unfortunately, I can't release a new version, so we would need to ask somebody from the team.

@elias8 elias8 merged commit 3473e93 into fluttercommunity:main Jan 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[android_intent_plus] issues from Flutter repository [android_intent] Intent Plugin: Type Mismatch between Dart's List<String> vs Java String[]

2 participants