[connectivity_plus] eliminate indirect FFI dependency (#65) #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty#65) Same as - package_info_plus_windows: fluttercommunity@cf13721 - path_provider_windows: flutter/plugins@2595703 - ... Moves the real implementation of connectivity_plus_linux behind a conditional export, instead exporting a stub on platforms that don't support dart:ffi. This avoids build breakage in web projects that have transitive dependencies on connectivity_plus (and thus connectivity_plus_linux due to manual endorsement). This will no longer be necessary once flutter/flutter#52267 is fixed, since only Linux builds will ever need to have code-level dependency on connectivity_plus_linux.
miquelbeltran
approved these changes
Dec 12, 2020
I think both. connectivity_plus_linux is going to be released for the first time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as
Moves the real implementation of connectivity_plus_linux behind a conditional export, instead of exporting a stub on platforms that don't support
dart:ffi. This avoids build breakage in web projects that have transitive dependencies on connectivity_plus (and thus connectivity_plus_linux due to manual endorsement).This will no longer be necessary once flutter/flutter#52267 is fixed since only Linux builds will ever need to have a code-level dependency on connectivity_plus_linux.