Skip to content

[battery_plus] rename method channel and plugins (#56) #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 12, 2020
Merged

[battery_plus] rename method channel and plugins (#56) #64

merged 7 commits into from
Dec 12, 2020

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Dec 11, 2020

Tested:

  • Android
  • iOS
  • Linux
  • macOS
  • Web
  • Windows

miquelbeltran
miquelbeltran approved these changes Dec 12, 2020
View reviewed changes
Copy link
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Like with share_plus, all the packages needs to be released again with versions and changelogs updated.

@jpnurmi
[battery_plus] rename method channels (fluttercommunity#56)
10f9cb8
@jpnurmi
[battery_plus] rename Android package etc. (fluttercommunity#56)
7daee05
@jpnurmi
[battery_plus] rename iOS class & files (fluttercommunity#56)
d8dfd8e
@jpnurmi
[battery_plus] rename web plugin (fluttercommunity#56)
b6a093e
@jpnurmi
[battery_plus] rename Linux plugin
be799b4 
Same as
- package_info_plus_windows:
  fluttercommunity@cf13721
- path_provider_windows:
  flutter/plugins@2595703

Moves the real implementation of battery_plus_linux behind a conditional
export, instead exporting a stub on platforms that don't support dart:ffi.
This avoids build breakage in web projects that have transitive dependencies
on battery_plus (and thus battery_plus_linux due to manual endorsement).

This will no longer be necessary once flutter/flutter#52267
is fixed, since only Linux builds will ever need to have code-level dependency
on battery_plus_linux.
@jpnurmi
[battery_plus] fix format
e38b142
@jpnurmi jpnurmi merged commit cf77598 into fluttercommunity:main Dec 12, 2020
@jpnurmi jpnurmi deleted the fix/battery_plus branch December 12, 2020 18:59
@sureace sureace mentioned this pull request Jan 28, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@miquelbeltran miquelbeltran miquelbeltran approved these changes

@mhadaily mhadaily Awaiting requested review from mhadaily

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpnurmi @miquelbeltran