Skip to content

Conversation

miquelbeltran
Copy link
Member

@miquelbeltran miquelbeltran commented Dec 8, 2020

Description

As reported in #49 we have a "collision" between the original package_info and our package_info_plus in Android.

As well, we also have an undetected issue because the channel ids are exactly the same.

In this PR I move the java files to a different java package folder, and as well I rename the channel ids.

Related Issues

#49

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@miquelbeltran miquelbeltran merged commit 5a7f17c into main Dec 8, 2020
@miquelbeltran miquelbeltran deleted the mb-fix-49 branch December 8, 2020 08:23
@miquelbeltran miquelbeltran changed the title [wip][package_info_plus] Fix #49 - rename platform channel id and move Java files [package_info_plus] Fix #49 - rename platform channel id and move Java files Dec 8, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant