General cleanup & fixup #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything matching .gitignore (git ls-files -i --exclude-standard).
First of all, connectivity_macos doesn't need its own example, but the shared example in the main connectivity_plus package will do. Secondly, the rest of connectivity_macos was moved to connectivity_plus_macos.
Probably because "src" was listed in .gitignore.
jpnurmi
force-pushed
the
feature/cleanup-n-fixup
branch
from
76c1416 to
09ba95e
Compare
Apparently it was a symbolic link before, but it got screwed up in the transition. The macOS version is now in a separate repo, so there's no reason to have a shared folder for Darwin in the main connectivity pkg.
jpnurmi
force-pushed
the
feature/cleanup-n-fixup
branch
from
d75a9f4 to
3711855
Compare
|
After these fixes, all examples run on all platforms that currently have the respective plugin in main. I have tested each example on Android, iOS, macOS, and Linux, where applicable. /cc @mhadaily |
|
LGTM @jpnurmi GREAT JOB. |
Closed
7 tasks
7 tasks
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.