Skip to content

Conversation

miquelbeltran
Copy link
Member

@miquelbeltran miquelbeltran commented Oct 30, 2020

Description

Moved all e2e tests to the example/test_driver folder.

Related Issues

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@jpnurmi
Copy link
Member

jpnurmi commented Oct 30, 2020

  • Move sensors_plus/test/sensors_e2e.dart to sensors_plus/example/test_driver/, and
  • remove connectivity_plus/test/connectivity_e2e.dart (looks like duplicate of the one in test_driver)?

P.S. Are these missing how does one run flutter drive for battery & share?

  • battery_plus/example/test_driver/battery_e2e_test.dart
  • share_plus/example/test_driver/share_e2e.dart

@miquelbeltran
Copy link
Member Author

Thanks for checking those!

  • sensors -> fixed
  • connectivity -> removed duplicated
  • share -> looks like the original share_test.dart was the e2e, so renamed and moved.
  • battery -> looks like the battery_e2e_test.dart was originally missing

@miquelbeltran
Copy link
Member Author

I added the missing batter_e2e_test.dart and I was able to run and pass the test with flutter drive --target=./test_driver/battery_e2e.dart

Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@miquelbeltran miquelbeltran merged commit 3d5bfc3 into main Nov 2, 2020
@miquelbeltran miquelbeltran deleted the mb-28-e2e-folders branch November 2, 2020 09:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants