Skip to content

Conversation

Abhishek01039
Copy link
Contributor

@Abhishek01039 Abhishek01039 commented Oct 27, 2020

Description

display1 is deprecated.
so we should change to headline4.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@Abhishek01039 Abhishek01039 changed the title removed deprecated display1 [android_alarm_manager_plus] removed deprecated display1 Oct 27, 2020
@Abhishek01039
Copy link
Contributor Author

Abhishek01039 commented Oct 27, 2020

Hello @slightfoot
can you please review this PR?
This is already merged to the main plugin repo so we need to update here as well.
Thanks

Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jpnurmi jpnurmi merged commit e446566 into fluttercommunity:main Oct 27, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants