Skip to content

Conversation

mhadaily
Copy link
Member

@mhadaily mhadaily commented Oct 2, 2020

@slightfoot slightfoot force-pushed the feature/battery_plus_linux branch 2 times, most recently from f3bc197 to 69c3203 Compare October 2, 2020 17:55
slightfoot pushed a commit that referenced this pull request Oct 2, 2020
slightfoot pushed a commit that referenced this pull request Oct 2, 2020
* setup pedantic

* lint fix with pedantic 1.9.0

Co-authored-by: Miquel Beltran <[email protected]>
@slightfoot slightfoot force-pushed the feature/battery_plus_linux branch from 69c3203 to 71cba3d Compare October 2, 2020 19:07
@slightfoot slightfoot self-requested a review October 22, 2020 18:52
@jpnurmi jpnurmi added the battery_plus Battery Plus Plugin label Oct 22, 2020
@miquelbeltran
Copy link
Member

run it on my machine and worked as expected 👍

@jpnurmi jpnurmi force-pushed the feature/battery_plus_linux branch 2 times, most recently from aee220d to 43129c2 Compare October 24, 2020 12:08
@jpnurmi
Copy link
Member

jpnurmi commented Oct 24, 2020

Rebased and resolved conflicts after merging #2 for macOS

@miquelbeltran
Copy link
Member

hi! whats stopping us from merging this one?

Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi! whats stopping us from merging this one?

This will be merged soon. :) We have just reviewed the code with @mhadaily.

@jpnurmi jpnurmi force-pushed the feature/battery_plus_linux branch from 4f11466 to c1ad0ef Compare December 9, 2020 20:22
@jpnurmi jpnurmi merged commit a3a585c into main Dec 9, 2020
@jpnurmi jpnurmi deleted the feature/battery_plus_linux branch December 9, 2020 20:30
jpnurmi added a commit to jpnurmi/plus_plugins that referenced this pull request Dec 13, 2020
jpnurmi added a commit to jpnurmi/plus_plugins that referenced this pull request Dec 13, 2020
jpnurmi added a commit to jpnurmi/plus_plugins that referenced this pull request Dec 13, 2020
jpnurmi added a commit to jpnurmi/plus_plugins that referenced this pull request Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

battery_plus Battery Plus Plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants