Skip to content

Conversation

nimafarzin-pr
Copy link

@nimafarzin-pr nimafarzin-pr commented Dec 13, 2023

Description

Investigating the WiFi name retrieval issue took quite a bit of time. While reviewing the package code and comments, I discovered that active GPS is required for getWifiName to function so I updated network_info_plus readme and added a note that starting with Android 8.0, turning on GPS (high accuracy) is necessary to get the SSID (your Wi-Fi network name).

Related Issues

WiFi name was not being received

e.g.

  • Related #99

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@vbuberen
Copy link
Collaborator

Why did you close the previous PR?

You still need to fix things mentioned in the comment here: #2455 (comment)

In the previous PR position of the new note was better.

@vbuberen
Copy link
Collaborator

I closed the previous PR because I realized I made a mistake in the commit structure that might have caused confusion. I've rewritten the comments in the new PR for better clarity.

It is not an issue. PR will be squashed anyway before merging, so I don't really care how you structure commits there, but only about the result of changes.

@vbuberen
Copy link
Collaborator

So will you address the points that I asked to address in my comment in the previous PR?

Copy link
Author

@nimafarzin-pr nimafarzin-pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fix pr structure issue

@vbuberen
Copy link
Collaborator

I asked you to provide a source of information that you added into the note, name the PR properly, etc. #2455 (comment)

You ignored this request. Closing this PR as invalid.

@vbuberen vbuberen closed this Feb 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants