Skip to content

fix(share_plus): reset isCalledBack on android correctly after closing share-sheet #2446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(share_plus): reset isCalledBack on android correctly after closing share-sheet #2446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25c2526
fix(share_plus): reset isCalledBack on android correctly after closin…
coder-with-a-bushido Dec 6, 2023
7d0392b
Merge branch 'main' into main
coder-with-a-bushido Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...s/share_plus/android/src/main/kotlin/dev/fluttercommunity/plus/share/MethodCallHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ internal class MethodCallHandler(
isWithResult,
)

manager.signalShareSheetCalledBack()
if (!isWithResult) {
if (isResultRequested) {
result.success("dev.fluttercommunity.plus/share/unavailable")
Expand All @@ -62,6 +63,7 @@ internal class MethodCallHandler(
isWithResult,
)

manager.signalShareSheetCalledBack()
if (!isWithResult) {
if (isResultRequested) {
result.success("dev.fluttercommunity.plus/share/unavailable")
Expand Down
8 changes: 8 additions & 0 deletions ...share_plus/android/src/main/kotlin/dev/fluttercommunity/plus/share/ShareSuccessManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,14 @@ internal class ShareSuccessManager(private val context: Context) : ActivityResul
}
}

/**
* Set the `isCalledBack` to `true`. Must be called in every share-sheet calling method
* before returning.
*/
fun signalShareSheetCalledBack(){
isCalledBack.set(true)
}

/**
* Must be called if `.startActivityForResult` is not available to avoid deadlocking.
*/
Expand Down