[package_info_plus_web] Added integration tests #19
Conversation
| @@ -1,3 +1,7 @@ | |||
| ## 0.1.1 | |||
There was a problem hiding this comment.
Hi @yash1200, I think we should not manually update the CHANGELOG.md on PRs, this will be done by the project maintainers on release.
In the https://github.com/fluttercommunity/plus_plugins/blob/main/CONTRIBUTING.md file we explain it better.
There was a problem hiding this comment.
Oh, didn't see that. I have reverted the package version.
| buildNumber: map['buildNumber'], | ||
| appName: versionMap['app_name'], | ||
| version: versionMap['version'], | ||
| buildNumber: versionMap['build_number'], |
| description: Web platform implementation of package_info_plus | ||
| homepage: https://github.com/fluttercommunity/plus_plugins/tree/main/packages/package_info_plus_web | ||
| version: 0.1.0 | ||
| version: 0.1.1 |
There was a problem hiding this comment.
As explained before, we will take care of updating the package version number when releasing.
|
Regarding the integration tests, there's already integration tests for the package_info_plus here: https://github.com/fluttercommunity/plus_plugins/blob/main/packages/package_info_plus/example/test_driver/package_info_e2e.dart which already cover Web. Or is this another kind of test? |
|
The tests file you mentioned expects all the values in web to be |
|
Hi @yash1200, we would like to merge the cleanup on We have decided that all integration tests should go into the If you want to continue with this PR, please revert all the changes except We really appreciate you contributing to the project, and thanks for taking time working on this! |
|
Understandable, I have removed the tests. |
|
Thank you! |
3 participants
Description
In this PR, I have removed unnecessary map in the
package_info_plus_web/lib/package_info_plus_web.dartfile and added integration tests forpackage_info_plus_webplugin.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?