Skip to content

Conversation

mhadaily
Copy link
Member

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • [ x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • [ x] All existing and new tests are passing.
  • [x ] I updated/added relevant documentation (doc comments with ///).
  • [x ] The analyzer (flutter analyze) does not report any problems on my PR.
  • [x ] I read and followed the Flutter Style Guide.
  • [x ] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • [x ] No, this is not a breaking change.

@mhadaily mhadaily requested a review from jpnurmi October 12, 2020 20:26
@mhadaily mhadaily merged commit 9e19d08 into main Oct 13, 2020
@mhadaily mhadaily deleted the fix/share_plus_version branch October 13, 2020 13:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants