-
-
Couldn't load subscription status.
- Fork 1.2k
feat(share_plus)!: Native share UI for Windows #1158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is not exactly a breaking change. EDIT: Feel free to share your feedback. GitHub actions are all green now. |
|
Adding integration tests & |
|
The latest release uses XFiles, does it support it? |
Web specific. |
|
Yeah, because of that. But shareFiles is now unsupported |
It still uses This Windows implementation is equivalent & still working similarly. Lines 135 to 152 in 69fbff0
|
|
Thanks for taking care of the changes in main @alexmercerind ! |
|
If version plus_plugins/packages/share_plus/share_plus/CHANGELOG.md Lines 1 to 11 in 0d5069d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tentatively looks good :) But I am not a Windows dev so I cannot comment, any devs familiar with Windows want to give it a look and comment?
|
Hey! Due to changes in our contributor guidelines, all PRs should now:
We would ask you kindly to update the PR following these changes. Thanks! |
* Platform specific implementation for using DataTransferManager on Windows * DataTransferManager is only used on (& available for) Windows 10 builds 17763 or higher. * On older Windows versions, existing old implementation is used i.e. launching mailto: URIs with subject & body query parameters. * Getting the share result is not supported on Windows. Thus, shareWithResult & shareFilesWithResult always return ShareResultStatus.unavailable. * This platform specific implementation beings supports for all existing methods available in package:share_plus to Windows, namely: share, shareFiles, shareWithResult, shareFilesWithResult, shareXFiles.
|
Hi! Thanks for the review process! |
|
Later today I will check this on my Windows machine |
|
I checked this locally and works flawlessly, let's go! |
packages/share_plus/share_plus_windows/test/share_plus_windows_test.dart
Show resolved
Hide resolved
|
Thanks for the work @alexmercerind ! |
Description
This brings support for all the existing
package:share_plusmethods to Windows:shareshareFilesshareWithResultshareFilesWithResultshareXFilesThis pull request adds the modern Share UI (i.e.
DataTransferManager) for Windows 10 or greater.It is very rich in experience & uses same UWP API through WRL.
The feature parity is equivalent as other platforms. Text, subject, images & files are supported.
On older Windows versions, existing behavior is kept (opening
mailto:URL with subject & body).Demo
share_plus_windows_alexmercerind.mp4
Related Issues
This PR closes following issues:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process.
pubspec.yamlandCHANGELOG.md.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?