-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Add breaking change doc for isFocusable #12159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Visit the preview URL for this PR (updated for commit fcd3bd5): https://flutter-docs-prod--pr12159-focusable-t0sm2pw2.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor updates and one question.
|
||
Landed in version: Not yet<br> | ||
In stable release: Not yet | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this in the main channel yet? If so, when did it land? Please add that info here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the PR is still pending review, will add the info after the PR is landed
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
## Summary | ||
|
||
The `SemanticsProperties.focusable` and `SemanticsConfiguration.isFocusable` | ||
parameters were deprecated in favor of the `SemanticsProperties.focused` and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
somwhere here should probably mention focused become nullable
`SemanticsConfiguration.isFocused` is a boolean to describe if the | ||
semantics node has input focus. | ||
|
||
The fix is the same with `SemanticsProperties.focusable` and `SemanticsProperties.focused`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section should talk about why this we decide to deprecate isFocusable
@hannah-hyj, please ping me when this is ready to land |
Description of what this PR is changing or adding, and why:
Issues fixed by this PR (if any):
PRs or commits this PR depends on (if any):
Presubmit checklist