Skip to content

Conversation

@johypark
Copy link

@johypark johypark commented Sep 30, 2024

Description of what this PR is changing or adding, and why:
I have to import another file in main and use package prefix in libraryURI
reference
Issues fixed by this PR (if any):

PRs or commits this PR depends on (if any):

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@johypark johypark requested review from a team, jmagman, parlough and sfshaza2 as code owners September 30, 2024 10:00
@google-cla
Copy link

google-cla bot commented Sep 30, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.


```swift
flutterEngine.run(withEntrypoint: "myOtherEntrypoint", libraryURI: "other_file.dart")
flutterEngine.run(withEntrypoint: "myOtherEntrypoint", libraryURI: "package:your_package_name/other_file.dart")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaaclarke is this right? The libraryURI should be package:your_package_name/other_file.dart?

flutter/engine#30726

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like advice that will not apply to everyone. So at a bare minimum it should be an added note instead of modifying the prevailing guidance.

In order to change the guidance I'd like to see a bug issued. In order to add the note I'd like to see an example project that demonstrates it's correctness.

@sfshaza2
Copy link
Contributor

/gcbrun

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit 117aa72):

https://flutter-docs-prod--pr11205-patch-1-yqv1floz.web.app

@sfshaza2
Copy link
Contributor

sfshaza2 commented Sep 30, 2024

@johypark, would you mind opening a bug against the flutter s/w repo for this? (As per @gaaclarke.)

@sfshaza2 sfshaza2 added the act.wait-for-customer Needs response from customer label Oct 2, 2024
@sfshaza2
Copy link
Contributor

Failing Greg's requests, I'm closing this PR.

@sfshaza2 sfshaza2 closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

act.wait-for-customer Needs response from customer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants