-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Update iOS flutterEngine libraryURI #11205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
|
||
| ```swift | ||
| flutterEngine.run(withEntrypoint: "myOtherEntrypoint", libraryURI: "other_file.dart") | ||
| flutterEngine.run(withEntrypoint: "myOtherEntrypoint", libraryURI: "package:your_package_name/other_file.dart") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaaclarke is this right? The libraryURI should be package:your_package_name/other_file.dart?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds like advice that will not apply to everyone. So at a bare minimum it should be an added note instead of modifying the prevailing guidance.
In order to change the guidance I'd like to see a bug issued. In order to add the note I'd like to see an example project that demonstrates it's correctness.
|
/gcbrun |
|
Visit the preview URL for this PR (updated for commit 117aa72): |
|
@johypark, would you mind opening a bug against the flutter s/w repo for this? (As per @gaaclarke.) |
|
Failing Greg's requests, I'm closing this PR. |
Description of what this PR is changing or adding, and why:
I have to import another file in main and use package prefix in libraryURI
reference
Issues fixed by this PR (if any):
PRs or commits this PR depends on (if any):
Presubmit checklist