Updated readme for web #754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
johnpryan
approved these changes
Mar 4, 2021
web/readme.md
Outdated
| ## Building samples code | ||
|
|
||
| Update Flutter and enable web support | ||
| Building web samples requires Flutter 2.0 or later. |
Contributor
There was a problem hiding this comment.
Is this something we need to say? Flutter 2.0 is stable channel now, I suspect we can assume that people looking at samples are expecting our samples expect the current SDK.
Otherwise I need to add this disclaimer to pretty much all of our samples and codelabs =)
Contributor
Author
There was a problem hiding this comment.
Right! I have removed this line now.
web/readme.md
Outdated
|
|
||
| ```console | ||
| $ flutter channel dev | ||
| $ flutter channel stable |
Contributor
There was a problem hiding this comment.
Actually this whole section is probably redundant because Flutter works on web on all channels.
domesticmouse
approved these changes
Mar 8, 2021
Contributor
|
Thanks @tusharojha! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Flutter 2 makes the web stable. Therefore, I have updated the readme file inside the web directory containing steps to run the web project.
@johnpryan PTAL and suggest changes if any.