[VeggieSeasons] added restore defaults feature #639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@domesticmouse & @redbrogdon kindly review and suggest changes if any. |
redbrogdon
reviewed
Jan 9, 2021
Contributor
redbrogdon
left a comment
redbrogdon
left a comment
There was a problem hiding this comment.
I like this idea. It definitely seems like a realistic way to work a dialog into the application.
@LongCatIsLooong or @xster, would either of you mind giving this a quick look to make sure it aligns with iOS UI guidelines? I don't know, for example, whether it's common to have a settings item act like a button this way.
LongCatIsLooong
approved these changes
Jan 12, 2021
LongCatIsLooong
left a comment
LongCatIsLooong
left a comment
There was a problem hiding this comment.
The CupertinoAlertDialog looks good to me. Thank you!
domesticmouse
approved these changes
Jan 12, 2021
Contributor
domesticmouse
left a comment
domesticmouse
left a comment
There was a problem hiding this comment.
Do we expose Apple's UIColor system colours somewhere? We should probably be using those, not hard coded constants...
domesticmouse
approved these changes
Jan 28, 2021
Contributor
|
PTAL @redbrogdon |
redbrogdon
approved these changes
Jan 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the
Restore Defaultsoption in the settings menu. The idea is to incorporate a feature that makes sense for adding aCupertinoAlertDialogin the app.Related Issue #546
Screenshot:
