-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Updated Veggieseasons to use CupertinoSearchTextField #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Veggieseasons to use CupertinoSearchTextField #630
Conversation
| child: CupertinoSearchTextField( | ||
| controller: controller, | ||
| focusNode: focusNode, | ||
| decoration: null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's by default a nullable type, so you can avoid passing null.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure @AyushBherwani1998 I'll do the necessary changes and revert you back
|
Hey @adarsh-technocrat, thanks for putting a PR for this. Sorry for the delays, was on a break. The idea is to completely remove the |
Okay, @AyushBherwani1998 I'll do the changes |
|
Hello, @AyushBherwani1998 is this fine to keep
|
|
Try to use
If you want to tweak the opacity, you can simply use |
758d46c to
0e528a4
Compare
Hey @AyushBherwani1998 I have done the changes in the PR it works very well as suggested by you just a request please review my PR once again. |
redbrogdon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this change. It's going to remove more lines of code than it adds, which is my favorite kind of PR.
3fe605c to
544d5f8
Compare
544d5f8 to
9a9fee7
Compare
|
Thanks, @adarsh-technocrat! I'm glad to see the new widget in place. |
Thank you @redbrogdon and @AyushBherwani1998! as this was my first PR that merge into |


Hello, @redbrogdon @AyushBherwani1998 👋🏼 it would be fantastic if you could review my very first PR here in the Flutter samples Repository.
The PR replaces the custom search field used by Veggieseasons sample app with CupertinoSearchTextField
fixes: #618