Skip to content

[Gallery] Exclude semantics for logo and change to hint for products on Shrine #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2020
Merged

[Gallery] Exclude semantics for logo and change to hint for products on Shrine #292

merged 2 commits into from
Jan 29, 2020

Conversation

@perclasson
Copy link
Contributor

@perclasson perclasson commented Jan 29, 2020 •
edited
Loading

  • We do not need to read out the Shrine logo for screen readers (from the a11y talk on Flutter Interact: https://youtu.be/bWbBgbmAdQs?t=849).
  • On VoiceOver we do not read onTapHint, so I changed it to hint.

Closes material-components/material-components-flutter-gallery#483

@perclasson perclasson merged commit fcac28d into flutter:master Jan 29, 2020
@perclasson perclasson deleted the exclude_logo_and_change_to_hint_for_products branch January 29, 2020 15:46
@0xZOne 0xZOne mentioned this pull request Oct 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rami-a rami-a rami-a approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Shrine - set hint text to products to indicate what happens when you tap them (1)

2 participants

@perclasson @rami-a