Skip to content

[simplistic_editor] - Fix delete key on desktop and backspace key on Web #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 5, 2022
Merged

[simplistic_editor] - Fix delete key on desktop and backspace key on Web #1458

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7a6d49
Do not propagate to default text intent
bleroux Oct 4, 2022
c2c4fc8
Add support for backward and forward delete (desktop)
bleroux Oct 4, 2022
ede5dcb
Update for nice auto-format
bleroux Oct 4, 2022
3e7bd69
Fix using delete key throws if at the end of the text
bleroux Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 22 additions & 9 deletions simplistic_editor/lib/basic_text_input_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ class BasicTextInputClientState extends State<BasicTextInputClient>
TextSelection get _selection => _value.selection;
late final Map<Type, Action<Intent>> _actions = <Type, Action<Intent>>{
DeleteCharacterIntent: CallbackAction<DeleteCharacterIntent>(
onInvoke: (intent) => _delete(),
onInvoke: (intent) => _delete(intent.forward),
),
ExtendSelectionByCharacterIntent:
CallbackAction<ExtendSelectionByCharacterIntent>(
Expand All @@ -315,22 +315,35 @@ class BasicTextInputClientState extends State<BasicTextInputClient>
PasteTextIntent: CallbackAction<PasteTextIntent>(
onInvoke: (intent) => pasteText(intent.cause),
),
DoNothingAndStopPropagationTextIntent: DoNothingAction(
consumesKey: false,
),
};

void _delete() {
void _delete(bool forward) {
if (_value.text.isEmpty) return;

late final TextRange deletedRange;
late final TextRange newComposing;
final int deletedLength =
_value.text.substring(0, _selection.baseOffset).characters.last.length;
late final String deletedText;
final int offset = _selection.baseOffset;

if (_selection.isCollapsed) {
if (_selection.baseOffset == 0) return;
deletedRange = TextRange(
start: _selection.baseOffset - deletedLength,
end: _selection.baseOffset,
);
if (forward) {
if (_selection.baseOffset == _value.text.length) return;
deletedText = _value.text.substring(offset).characters.first;
deletedRange = TextRange(
start: offset,
end: offset + deletedText.length,
);
} else {
if (_selection.baseOffset == 0) return;
deletedText = _value.text.substring(0, offset).characters.last;
deletedRange = TextRange(
start: offset - deletedText.length,
end: offset,
);
}
} else {
deletedRange = _selection;
}
Expand Down