Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@mvanbeusekom
Copy link
Contributor

Adds the Android implementation of the PlatformNavigationDelegate.

Part of issue flutter/flutter#94051

If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@mvanbeusekom mvanbeusekom added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Sep 26, 2022
@github-actions github-actions bot added p: webview_flutter Edits files for a webview_flutter plugin platform-android labels Sep 26, 2022
@mvanbeusekom
Copy link
Contributor Author

Hi @bparrishMines, I have added the requested changes would appreciate another review.

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming formatting will be fixed

@mvanbeusekom mvanbeusekom merged commit a625523 into flutter:v4_webview Oct 27, 2022
@mvanbeusekom mvanbeusekom deleted the v4_webview_android_navigation_delegate branch October 27, 2022 13:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: webview_flutter Edits files for a webview_flutter plugin platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants