Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@scheglov
Copy link
Contributor

We would like to land https://dart-review.googlesource.com/c/sdk/+/226962 in the Dart analyzer and fixing existing violations.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaaclarke
Copy link
Member

Do you know how to make it publishable? You have to update the version number in pubspec.yaml, put a description in CHANGELOG.md.

@scheglov
Copy link
Contributor Author

I did not know about this bot, made some changes, let's see if the bot is happy.

@gaaclarke
Copy link
Member

Yep, this looks good. The last CI check is because the tree is red, we were having some networking flakes for ci steps. Let me poke it again to see if I can flush it out. This is all set though, thanks.

@scheglov scheglov force-pushed the fix-UNUSED_ELEMENT_PARAMETER branch from 021e674 to 82981c7 Compare January 13, 2022 21:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants