Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@jokerttu
Copy link
Contributor

@jokerttu jokerttu commented Nov 9, 2021

Fixes canLaunch implementation for file scheme.
canLaunch incorrectly returned a false response to launchable file scheme URLs.
Fix uses same method than g_app_info_launch_default_for_uri does internally to detect default application for URI.

Fixes #93326

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jokerttu

This comment has been minimized.

@jokerttu jokerttu force-pushed the url_launcher_linux_file_scheme_support branch from b38d534 to 41e109d Compare November 9, 2021 18:13
@stuartmorgan-g
Copy link
Contributor

Thanks for the submission! Marking as a draft per the comment above; please remove the draft designation once the tests have been reworked.

@stuartmorgan-g stuartmorgan-g marked this pull request as draft November 10, 2021 04:07
@stuartmorgan-g
Copy link
Contributor

Adding @robert-ancell for second review.

Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good with the requested changes, thanks @jokerttu.

@godofredoc godofredoc changed the base branch from master to main January 6, 2022 22:50
@jokerttu jokerttu changed the title [url_launcher_linux] file scheme support for canLaunch [url_launcher_linux] file resource URI support for canLaunch Jan 11, 2022
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment nit.

This will need final approval from @robert-ancell as well.

Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jokerttu!

@stuartmorgan-g stuartmorgan-g added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Jan 12, 2022
@fluttergithubbot fluttergithubbot merged commit 4f1c6f3 into flutter:main Jan 16, 2022
@jokerttu jokerttu deleted the url_launcher_linux_file_scheme_support branch October 7, 2022 07:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes p: url_launcher platform-linux waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[url_launcher_linux] canLaunch does not detect launchable URIs with file scheme

4 participants