This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[url_launcher_linux] file resource URI support for canLaunch #4491
Merged
fluttergithubbot
merged 18 commits into
flutter:main
from
CodemateLtd:url_launcher_linux_file_scheme_support
Jan 16, 2022
Merged
[url_launcher_linux] file resource URI support for canLaunch #4491
fluttergithubbot
merged 18 commits into
flutter:main
from
CodemateLtd:url_launcher_linux_file_scheme_support
Jan 16, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
b38d534 to
41e109d
Compare
Contributor
|
Thanks for the submission! Marking as a draft per the comment above; please remove the draft designation once the tests have been reworked. |
stuartmorgan-g
suggested changes
Jan 6, 2022
packages/url_launcher/url_launcher_linux/linux/url_launcher_plugin.cc
Outdated
Show resolved
Hide resolved
packages/url_launcher/url_launcher_linux/linux/url_launcher_plugin.cc
Outdated
Show resolved
Hide resolved
packages/url_launcher/url_launcher_linux/linux/url_launcher_plugin.cc
Outdated
Show resolved
Hide resolved
packages/url_launcher/url_launcher_linux/linux/test/url_launcher_linux_test.cc
Outdated
Show resolved
Hide resolved
Contributor
|
Adding @robert-ancell for second review. |
packages/url_launcher/url_launcher_linux/linux/test/url_launcher_linux_test.cc
Outdated
Show resolved
Hide resolved
robert-ancell
suggested changes
Jan 6, 2022
Contributor
robert-ancell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good with the requested changes, thanks @jokerttu.
stuartmorgan-g
suggested changes
Jan 7, 2022
packages/url_launcher/url_launcher_linux/linux/url_launcher_plugin.cc
Outdated
Show resolved
Hide resolved
stuartmorgan-g
approved these changes
Jan 11, 2022
Contributor
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a comment nit.
This will need final approval from @robert-ancell as well.
packages/url_launcher/url_launcher_linux/linux/url_launcher_plugin.cc
Outdated
Show resolved
Hide resolved
robert-ancell
approved these changes
Jan 11, 2022
Contributor
robert-ancell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jokerttu!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yes
p: url_launcher
platform-linux
waiting for tree to go green
(Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
canLaunchimplementation forfilescheme.canLaunchincorrectly returned afalseresponse to launchable file scheme URLs.Fix uses same method than g_app_info_launch_default_for_uri does internally to detect default application for URI.
Fixes #93326
Pre-launch Checklist
dart format.)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.