Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Make java-test output more useful #4184

Merged
merged 5 commits into from
Jul 24, 2021
Merged

Make java-test output more useful #4184

merged 5 commits into from
Jul 24, 2021

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Jul 22, 2021 •
edited
Loading

This PR:

  • removes the --info from the ./gradlew testDebugUnitTest call
  • Adds a standard testing configuration to all android/build.gradle files.

Output turns into:
Screen Shot 2021-07-22 at 5 08 04 PM

Fixes flutter/flutter#85478

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Jul 22, 2021
@bparrishMines bparrishMines changed the title Unit tests Make java-test output more useful Jul 23, 2021
@bparrishMines bparrishMines requested review from stuartmorgan-g and removed request for cyanglaz and LHLL July 23, 2021 01:36
stuartmorgan-g
stuartmorgan-g approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

(I just filed a bug for the flaky iOS video_player test, and kicked off another run of it here; it's been causing me issues as well.)

@bparrishMines bparrishMines merged commit 7d49fd4 into flutter:master Jul 24, 2021
@bparrishMines bparrishMines deleted the unit_tests branch July 24, 2021 23:06
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 27, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2021
@engine-flutter-autoroll
7d49fd4 Make java-test output more useful (flutter/plugins#4184)
02dbc0a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 27, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2021
@engine-flutter-autoroll
7d49fd4 Make java-test output more useful (flutter/plugins#4184)
658d9f4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 27, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 27, 2021
@engine-flutter-autoroll
7d49fd4 Make java-test output more useful (flutter/plugins#4184)
f7e4a46
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@bparrishMines @fotiDim
Make java-test output more useful (flutter#4184)
e4deadc
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@bparrishMines @amantoux
Make java-test output more useful (flutter#4184)
d91e52a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes p: android_alarm_manager p: android_intent p: battery Edits files for a battery plugin p: camera p: connectivity p: device_info p: espresso p: flutter_plugin_android_lifecycle p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: local_auth p: package_info p: path_provider p: quick_actions p: sensors p: share p: shared_preferences p: url_launcher p: video_player p: webview_flutter Edits files for a webview_flutter plugin p: wifi_info_flutter platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make java-test output more useful
2 participants
@bparrishMines @stuartmorgan-g