Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] Fix rotation when camera is a source #4019

Merged
merged 3 commits into from
Jun 8, 2021
Merged

[image_picker] Fix rotation when camera is a source #4019

merged 3 commits into from
Jun 8, 2021

Conversation

@ydag
Copy link
Contributor

@ydag ydag commented Jun 7, 2021 •
edited
Loading

This PR fixes a rotation problem where when the camera is chosen as a source and additional parameters are added. This change is related to #3873. isMetadataAvailable parameter is used to handle the rotation problem for limited access to the photo library and it should be YES for all other occasions.

Related issues:

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format. See plugin_tool format)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ydag ydag requested a review from cyanglaz as a code owner June 7, 2021 07:54
@google-cla google-cla bot added the cla: yes label Jun 7, 2021
@ydag ydag changed the title Fix rotation when camera is a source [image_picker] Fix rotation when camera is a source Jun 7, 2021
@ydag ydag mentioned this pull request Jun 7, 2021
Closed
mvanbeusekom
mvanbeusekom approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvanbeusekom mvanbeusekom merged commit 70fcc65 into flutter:master Jun 8, 2021
@mvanbeusekom mvanbeusekom deleted the fix_rotation_camera branch June 8, 2021 07:05
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 8, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 8, 2021
@engine-flutter-autoroll
70fcc65 [image_picker] Fix rotation when camera is a source (flutter/…
a64f925 
…plugins#4019)
fluttergithubbot pushed a commit to flutter/flutter that referenced this pull request Jun 8, 2021
@engine-flutter-autoroll
70fcc65 [image_picker] Fix rotation when camera is a source (flutter/…
5c54e70 
…plugins#4019) (#84176)
fotiDim pushed a commit to fotiDim/plugins that referenced this pull request Sep 13, 2021
@ydag @fotiDim
[image_picker] Fix rotation when camera is a source (flutter#4019)
c5df184 
* Fix isMetadataAvailable bool

* Add unit test

* Update CHANGELOG and version
jolmiracle pushed a commit to miracle-as/webview_flutter that referenced this pull request Sep 24, 2021
@ydag @jolmiracle
[image_picker] Fix rotation when camera is a source (flutter#4019)
14c6e3d 
* Fix isMetadataAvailable bool

* Add unit test

* Update CHANGELOG and version
# Conflicts:
#	packages/image_picker/image_picker/CHANGELOG.md
#	packages/image_picker/image_picker/pubspec.yaml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

1 more reviewer

@mvanbeusekom mvanbeusekom mvanbeusekom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes p: image_picker platform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[image_picker] Incorrect image rotation when selecting & resizing a portrait photo on iOS 14 with Limited Photos permission

3 participants

@ydag @mvanbeusekom @stuartmorgan-g