Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/url_launcher/url_launcher_web/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 0.1.3+2

- Fix a typo in a test name and fix some style inconsistencies.

# 0.1.3+1

- Depend explicitly on the `platform_interface` package that adds the `webOnlyWindowName` parameter.
Expand Down
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher_web/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ homepage: https://github.com/flutter/plugins/tree/master/packages/url_launcher/u
# 0.1.y+z is compatible with 1.0.0, if you land a breaking change bump
# the version to 2.0.0.
# See more details: https://github.com/flutter/flutter/wiki/Package-migration-to-1.0.0
version: 0.1.3+1
version: 0.1.3+2

flutter:
plugin:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -145,17 +145,17 @@ void main() {

verify(mockWindow.open('sms:+19725551212?body=hello%20there', ''));
});
test('setting oOnlyLinkTarget as _self opens the url in the same tab',
test('setting webOnlyLinkTarget as _self opens the url in the same tab',
() {
plugin.openNewWindow("https://www.google.com",
webOnlyWindowName: "_self");
plugin.openNewWindow('https://www.google.com',
webOnlyWindowName: '_self');
verify(mockWindow.open('https://www.google.com', '_self'));
});

test('setting webOnlyLinkTarget as _blank opens the url in a new tab',
() {
plugin.openNewWindow("https://www.google.com",
webOnlyWindowName: "_blank");
plugin.openNewWindow('https://www.google.com',
webOnlyWindowName: '_blank');
verify(mockWindow.open('https://www.google.com', '_blank'));
});

Expand Down Expand Up @@ -197,9 +197,9 @@ void main() {
test(
'mailto urls should use _blank if webOnlyWindowName is set as _blank',
() {
plugin.openNewWindow("mailto:[email protected]",
webOnlyWindowName: "_blank");
verify(mockWindow.open("mailto:[email protected]", "_blank"));
plugin.openNewWindow('mailto:[email protected]',
webOnlyWindowName: '_blank');
verify(mockWindow.open('mailto:[email protected]', '_blank'));
});
});
});
Expand Down