[pigeon] Improves documentation of `ProxyApi` and moves helper functions to a separate file #9756

bparrishMines · 2025-08-05T20:00:32Z

Follow up to #9515 that moves Dart ProxyApi methods to a separate file.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

…roxy_apis

gemini-code-assist

Code Review

This pull request is a great refactoring effort. Moving the ProxyAPI generation logic into a dedicated helper file (proxy_api_generator_helper.dart) significantly improves the modularity and maintainability of the Dart generator. The extensive documentation updates are also a major improvement, making the concepts around ProxyAPIs much clearer for developers.

I've found one minor point of feedback regarding the wording in the CHANGELOG.md to more accurately reflect the changes. Overall, this is a high-quality contribution.

gemini-code-assist · 2025-08-05T20:02:04Z

packages/pigeon/CHANGELOG.md

+* Moves helper classes for generating Dart portion of ProxyAPIs.
+* Improves documentation of `ProxyApi` annotation and internal Dart ProxyAPI helper classes.


For clarity and accuracy, it would be better to refer to the moved code as "functions" rather than "classes", as the refactoring primarily involved moving top-level helper functions.

Suggested change

* Moves helper classes for generating Dart portion of ProxyAPIs.

* Improves documentation of `ProxyApi` annotation and internal Dart ProxyAPI helper classes.

* Moves helper functions for generating Dart portion of ProxyAPIs.

* Improves documentation of `ProxyApi` annotation and internal Dart ProxyAPI helper functions.

…roxy_apis

bparrishMines · 2025-08-06T13:50:11Z

packages/pigeon/lib/src/pigeon_lib.dart

+/// references to the Dart proxy classes and the native type instances. This
+/// also provides automatic garbage collection of native type instances when its
+/// associated Dart proxy class instance is garbage collected.
 class ProxyApi {


@tarrinneal @stuartmorgan-g Let me know if this explanation of "what is a ProxyAPI" makes sense.

…roxy_apis

tarrinneal

Seems like good improvements

…per functions to a separate file (flutter/packages#9756)

flutter/packages@a114ac2...08a9b2c 2025-08-11 [email protected] [in_app_purchase_storekit] Add support for quantity in consumable product purchases (#171570) (flutter/packages#9698) 2025-08-11 [email protected] [pigeon] Improves documentation of `ProxyApi` and moves helper functions to a separate file (flutter/packages#9756) 2025-08-11 [email protected] Roll Flutter from 1590543 to e2a347b (1 revision) (flutter/packages#9784) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

* main: (56 commits) [go_router_builder] Support extension types (flutter#9458) Roll Flutter from e2a347b14a18 to 34c2a3b158b2 (41 revisions) (flutter#9803) [go_router_builder] Migrate to Element2 API and update dependencies (flutter#9649) [in_app_purchase_storekit] Add support for quantity in consumable product purchases (#171570) (flutter#9698) [pigeon] Improves documentation of `ProxyApi` and moves helper functions to a separate file (flutter#9756) Roll Flutter from 1590543f6794 to e2a347b14a18 (1 revision) (flutter#9784) [camera_avfoundation] Implementation swift migration - part 11 (flutter#9690) [camera_avfoundation] Fix crash when streaming while recording (flutter#9691) Roll Flutter from 38217906e95c to 1590543f6794 (14 revisions) (flutter#9780) Roll Flutter from 92a6bfbfd6ef to 38217906e95c (17 revisions) (flutter#9778) [video_player] Improve KVO handling on iOS (flutter#9718) [dependabot]: Bump the test-dependencies group across 15 directories with 7 updates (flutter#9736) Roll Flutter from 9de63a03428f to 92a6bfbfd6ef (11 revisions) (flutter#9769) [google_maps_flutter_platform_interface] Add Advanced markers support (flutter#9737) [camera_android_camerax] Re-land "Force new Surface for each SurfaceRequest" (flutter#9760) [google_maps_flutter] Add ability to perform Google Maps SDK warmup (flutter#9674) Roll Flutter from 59fc766c6fdf to 9de63a03428f (6 revisions) (flutter#9764) [webview_flutter_wkwebview] Extended Web View API on iOS to add flexibility when working with local HTML content (flutter#8787) [local_auth] Differentiate iOS authentication errors (flutter#9705) manual roll to 59fc766c6fdfd03d0983fc95ce8b76793a300dd5 (flutter#9758) ... # Conflicts: # packages/go_router_builder/lib/src/type_helpers.dart # packages/go_router_builder/pubspec.yaml

…r#173625) flutter/packages@a114ac2...08a9b2c 2025-08-11 [email protected] [in_app_purchase_storekit] Add support for quantity in consumable product purchases (flutter#171570) (flutter/packages#9698) 2025-08-11 [email protected] [pigeon] Improves documentation of `ProxyApi` and moves helper functions to a separate file (flutter/packages#9756) 2025-08-11 [email protected] Roll Flutter from 1590543 to e2a347b (1 revision) (flutter/packages#9784) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@stuartmorgan-g

A copy of @stuartmorgan-g change at flutter/packages#9805 > Initial attempt at adding guidance for GCAfGH to try cut down on the behavior observed so far that it: > - Almost always includes generic praise for the PR, which is unhelpful since the agent has no context for evaluating what PRs we actually want (see [this particularly problematic example](flutter/packages#9795 (review))) > - Appears to trust PR descriptions. E.g., recently praising a PR that was missing tests of most of the PR, but had a PR description saying it included extensive testing, as being extremely well tested. Here are examples of summaries from the packages repo before and after this change: Before (praise like "great refactoring effort", "significantly improves the modularity and maintainability", "extensive documentation updates are also a major improvement"): > This pull request is a great refactoring effort. Moving the ProxyAPI generation logic into a dedicated helper file (`proxy_api_generator_helper.dart`) significantly improves the modularity and maintainability of the Dart generator. The extensive documentation updates are also a major improvement, making the concepts around ProxyAPIs much clearer for developers. flutter/packages#9756 After (drier, describing the actual change without making normative evaluation): > This pull request introduces a new `clearAuthorizationToken` method across all layers of the `google_sign_in` plugin. This allows developers to manually clear a cached authorization token if it becomes invalid. The implementation is handled natively on Android, is a no-op on iOS (as the SDK handles it), and clears a local cache on the web. The changes include updates to the platform interface, implementations for each platform, and corresponding tests and documentation. flutter/packages#9846 (review) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

@stuartmorgan-g

A copy of @stuartmorgan-g change at flutter/packages#9805 > Initial attempt at adding guidance for GCAfGH to try cut down on the behavior observed so far that it: > - Almost always includes generic praise for the PR, which is unhelpful since the agent has no context for evaluating what PRs we actually want (see [this particularly problematic example](flutter/packages#9795 (review))) > - Appears to trust PR descriptions. E.g., recently praising a PR that was missing tests of most of the PR, but had a PR description saying it included extensive testing, as being extremely well tested. Here are examples of summaries from the packages repo before and after this change: Before (praise like "great refactoring effort", "significantly improves the modularity and maintainability", "extensive documentation updates are also a major improvement"): > This pull request is a great refactoring effort. Moving the ProxyAPI generation logic into a dedicated helper file (`proxy_api_generator_helper.dart`) significantly improves the modularity and maintainability of the Dart generator. The extensive documentation updates are also a major improvement, making the concepts around ProxyAPIs much clearer for developers. flutter/packages#9756 After (drier, describing the actual change without making normative evaluation): > This pull request introduces a new `clearAuthorizationToken` method across all layers of the `google_sign_in` plugin. This allows developers to manually clear a cached authorization token if it becomes invalid. The implementation is handled natively on Android, is a no-op on iOS (as the SDK handles it), and clears a local cache on the web. The changes include updates to the platform interface, implementations for each platform, and corresponding tests and documentation. flutter/packages#9846 (review) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

@stuartmorgan-g

A copy of @stuartmorgan-g change at flutter/packages#9805 > Initial attempt at adding guidance for GCAfGH to try cut down on the behavior observed so far that it: > - Almost always includes generic praise for the PR, which is unhelpful since the agent has no context for evaluating what PRs we actually want (see [this particularly problematic example](flutter/packages#9795 (review))) > - Appears to trust PR descriptions. E.g., recently praising a PR that was missing tests of most of the PR, but had a PR description saying it included extensive testing, as being extremely well tested. Here are examples of summaries from the packages repo before and after this change: Before (praise like "great refactoring effort", "significantly improves the modularity and maintainability", "extensive documentation updates are also a major improvement"): > This pull request is a great refactoring effort. Moving the ProxyAPI generation logic into a dedicated helper file (`proxy_api_generator_helper.dart`) significantly improves the modularity and maintainability of the Dart generator. The extensive documentation updates are also a major improvement, making the concepts around ProxyAPIs much clearer for developers. flutter/packages#9756 After (drier, describing the actual change without making normative evaluation): > This pull request introduces a new `clearAuthorizationToken` method across all layers of the `google_sign_in` plugin. This allows developers to manually clear a cached authorization token if it becomes invalid. The implementation is handled natively on Android, is a no-op on iOS (as the SDK handles it), and clears a local cache on the web. The changes include updates to the platform interface, implementations for each platform, and corresponding tests and documentation. flutter/packages#9846 (review) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

@stuartmorgan-g

…74000) A copy of @stuartmorgan-g change at flutter/packages#9805 > Initial attempt at adding guidance for GCAfGH to try cut down on the behavior observed so far that it: > - Almost always includes generic praise for the PR, which is unhelpful since the agent has no context for evaluating what PRs we actually want (see [this particularly problematic example](flutter/packages#9795 (review))) > - Appears to trust PR descriptions. E.g., recently praising a PR that was missing tests of most of the PR, but had a PR description saying it included extensive testing, as being extremely well tested. Here are examples of summaries from the packages repo before and after this change: Before (praise like "great refactoring effort", "significantly improves the modularity and maintainability", "extensive documentation updates are also a major improvement"): > This pull request is a great refactoring effort. Moving the ProxyAPI generation logic into a dedicated helper file (`proxy_api_generator_helper.dart`) significantly improves the modularity and maintainability of the Dart generator. The extensive documentation updates are also a major improvement, making the concepts around ProxyAPIs much clearer for developers. flutter/packages#9756 After (drier, describing the actual change without making normative evaluation): > This pull request introduces a new `clearAuthorizationToken` method across all layers of the `google_sign_in` plugin. This allows developers to manually clear a cached authorization token if it becomes invalid. The implementation is handled natively on Android, is a no-op on iOS (as the SDK handles it), and clears a local cache on the web. The changes include updates to the platform interface, implementations for each platform, and corresponding tests and documentation. flutter/packages#9846 (review) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

@stuartmorgan-g

…74000) A copy of @stuartmorgan-g change at flutter/packages#9805 > Initial attempt at adding guidance for GCAfGH to try cut down on the behavior observed so far that it: > - Almost always includes generic praise for the PR, which is unhelpful since the agent has no context for evaluating what PRs we actually want (see [this particularly problematic example](flutter/packages#9795 (review))) > - Appears to trust PR descriptions. E.g., recently praising a PR that was missing tests of most of the PR, but had a PR description saying it included extensive testing, as being extremely well tested. Here are examples of summaries from the packages repo before and after this change: Before (praise like "great refactoring effort", "significantly improves the modularity and maintainability", "extensive documentation updates are also a major improvement"): > This pull request is a great refactoring effort. Moving the ProxyAPI generation logic into a dedicated helper file (`proxy_api_generator_helper.dart`) significantly improves the modularity and maintainability of the Dart generator. The extensive documentation updates are also a major improvement, making the concepts around ProxyAPIs much clearer for developers. flutter/packages#9756 After (drier, describing the actual change without making normative evaluation): > This pull request introduces a new `clearAuthorizationToken` method across all layers of the `google_sign_in` plugin. This allows developers to manually clear a cached authorization token if it becomes invalid. The implementation is handled natively on Android, is a no-op on iOS (as the SDK handles it), and clears a local cache on the web. The changes include updates to the platform interface, implementations for each platform, and corresponding tests and documentation. flutter/packages#9846 (review) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…r#173625) flutter/packages@a114ac2...08a9b2c 2025-08-11 [email protected] [in_app_purchase_storekit] Add support for quantity in consumable product purchases (flutter#171570) (flutter/packages#9698) 2025-08-11 [email protected] [pigeon] Improves documentation of `ProxyApi` and moves helper functions to a separate file (flutter/packages#9756) 2025-08-11 [email protected] Roll Flutter from 1590543 to e2a347b (1 revision) (flutter/packages#9784) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@stuartmorgan-g

…74000) A copy of @stuartmorgan-g change at flutter/packages#9805 > Initial attempt at adding guidance for GCAfGH to try cut down on the behavior observed so far that it: > - Almost always includes generic praise for the PR, which is unhelpful since the agent has no context for evaluating what PRs we actually want (see [this particularly problematic example](flutter/packages#9795 (review))) > - Appears to trust PR descriptions. E.g., recently praising a PR that was missing tests of most of the PR, but had a PR description saying it included extensive testing, as being extremely well tested. Here are examples of summaries from the packages repo before and after this change: Before (praise like "great refactoring effort", "significantly improves the modularity and maintainability", "extensive documentation updates are also a major improvement"): > This pull request is a great refactoring effort. Moving the ProxyAPI generation logic into a dedicated helper file (`proxy_api_generator_helper.dart`) significantly improves the modularity and maintainability of the Dart generator. The extensive documentation updates are also a major improvement, making the concepts around ProxyAPIs much clearer for developers. flutter/packages#9756 After (drier, describing the actual change without making normative evaluation): > This pull request introduces a new `clearAuthorizationToken` method across all layers of the `google_sign_in` plugin. This allows developers to manually clear a cached authorization token if it becomes invalid. The implementation is handled natively on Android, is a no-op on iOS (as the SDK handles it), and clears a local cache on the web. The changes include updates to the platform interface, implementations for each platform, and corresponding tests and documentation. flutter/packages#9846 (review) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…r#173625) flutter/packages@a114ac2...08a9b2c 2025-08-11 [email protected] [in_app_purchase_storekit] Add support for quantity in consumable product purchases (flutter#171570) (flutter/packages#9698) 2025-08-11 [email protected] [pigeon] Improves documentation of `ProxyApi` and moves helper functions to a separate file (flutter/packages#9756) 2025-08-11 [email protected] Roll Flutter from 1590543 to e2a347b (1 revision) (flutter/packages#9784) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@stuartmorgan-g

…74000) A copy of @stuartmorgan-g change at flutter/packages#9805 > Initial attempt at adding guidance for GCAfGH to try cut down on the behavior observed so far that it: > - Almost always includes generic praise for the PR, which is unhelpful since the agent has no context for evaluating what PRs we actually want (see [this particularly problematic example](flutter/packages#9795 (review))) > - Appears to trust PR descriptions. E.g., recently praising a PR that was missing tests of most of the PR, but had a PR description saying it included extensive testing, as being extremely well tested. Here are examples of summaries from the packages repo before and after this change: Before (praise like "great refactoring effort", "significantly improves the modularity and maintainability", "extensive documentation updates are also a major improvement"): > This pull request is a great refactoring effort. Moving the ProxyAPI generation logic into a dedicated helper file (`proxy_api_generator_helper.dart`) significantly improves the modularity and maintainability of the Dart generator. The extensive documentation updates are also a major improvement, making the concepts around ProxyAPIs much clearer for developers. flutter/packages#9756 After (drier, describing the actual change without making normative evaluation): > This pull request introduces a new `clearAuthorizationToken` method across all layers of the `google_sign_in` plugin. This allows developers to manually clear a cached authorization token if it becomes invalid. The implementation is handled natively on Android, is a no-op on iOS (as the SDK handles it), and clears a local cache on the web. The changes include updates to the platform interface, implementations for each platform, and corresponding tests and documentation. flutter/packages#9846 (review) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

@stuartmorgan-g

…74000) A copy of @stuartmorgan-g change at flutter/packages#9805 > Initial attempt at adding guidance for GCAfGH to try cut down on the behavior observed so far that it: > - Almost always includes generic praise for the PR, which is unhelpful since the agent has no context for evaluating what PRs we actually want (see [this particularly problematic example](flutter/packages#9795 (review))) > - Appears to trust PR descriptions. E.g., recently praising a PR that was missing tests of most of the PR, but had a PR description saying it included extensive testing, as being extremely well tested. Here are examples of summaries from the packages repo before and after this change: Before (praise like "great refactoring effort", "significantly improves the modularity and maintainability", "extensive documentation updates are also a major improvement"): > This pull request is a great refactoring effort. Moving the ProxyAPI generation logic into a dedicated helper file (`proxy_api_generator_helper.dart`) significantly improves the modularity and maintainability of the Dart generator. The extensive documentation updates are also a major improvement, making the concepts around ProxyAPIs much clearer for developers. flutter/packages#9756 After (drier, describing the actual change without making normative evaluation): > This pull request introduces a new `clearAuthorizationToken` method across all layers of the `google_sign_in` plugin. This allows developers to manually clear a cached authorization token if it becomes invalid. The implementation is handled natively on Android, is a no-op on iOS (as the SDK handles it), and clears a local cache on the web. The changes include updates to the platform interface, implementations for each platform, and corresponding tests and documentation. flutter/packages#9846 (review) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

bparrishMines added 11 commits July 21, 2025 14:42

move methods

22331a4

rename methods

d52cab6

Merge branch 'main' of github.com:flutter/packages into pigeon_move_p…

58485fe

…roxy_apis

Merge branch 'main' of github.com:flutter/packages into pigeon_move_p…

6ad2125

…roxy_apis

Merge branch 'main' of github.com:flutter/packages into pigeon_move_p…

1c8ad6b

…roxy_apis

update ast docs

246f301

pigeon lib update

41fe93d

update pigeon lib internal

d377d6a

make docs more consistent

dac306a

version bump and regen code

eb2cefe

Merge branch 'main' of github.com:flutter/packages into pigeon_move_p…

36816f3

…roxy_apis

github-actions bot added the p: pigeon label Aug 5, 2025

gemini-code-assist bot reviewed Aug 5, 2025

View reviewed changes

bparrishMines added 3 commits August 5, 2025 16:05

change to calling the functions

9fc6dd0

fix unit tests

52a35c9

Merge branch 'main' of github.com:flutter/packages into pigeon_move_p…

aca82a6

…roxy_apis

bparrishMines changed the title ~~Pigeon move proxy apis~~ [pigeon] Improves documentation of ProxyApi and moves helper functions to a separate file Aug 6, 2025

bparrishMines added 2 commits August 6, 2025 09:45

update docs a bit

15e92c2

small improve to annotation

1e05d33

bparrishMines commented Aug 6, 2025

View reviewed changes

mall changes again

98fab4f

bparrishMines marked this pull request as ready for review August 6, 2025 13:52

bparrishMines requested a review from tarrinneal as a code owner August 6, 2025 13:52

Merge branch 'main' of github.com:flutter/packages into pigeon_move_p…

f396c7a

…roxy_apis

tarrinneal approved these changes Aug 7, 2025

View reviewed changes

bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 11, 2025

auto-submit bot merged commit 3f38423 into flutter:main Aug 11, 2025
80 checks passed

bparrishMines deleted the pigeon_move_proxy_apis branch August 11, 2025 20:35

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 12, 2025

3f38423ba [pigeon] Improves documentation of ProxyApi and moves hel…

6afa02b

…per functions to a separate file (flutter/packages#9756)

engine-flutter-autoroll mentioned this pull request Aug 12, 2025

Roll Packages from a114ac22b1d0 to 08a9b2cc46dd (3 revisions) flutter/flutter#173625

Merged

jmagman mentioned this pull request Aug 18, 2025

Add review agent style guidelines to .gemini/styleguide.md flutter/flutter#174000

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[pigeon] Improves documentation of `ProxyApi` and moves helper functions to a separate file #9756

[pigeon] Improves documentation of `ProxyApi` and moves helper functions to a separate file #9756

Uh oh!

bparrishMines commented Aug 5, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Aug 5, 2025

Uh oh!

bparrishMines Aug 6, 2025

Uh oh!

tarrinneal left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		* Moves helper classes for generating Dart portion of ProxyAPIs.
		* Improves documentation of `ProxyApi` annotation and internal Dart ProxyAPI helper classes.

[pigeon] Improves documentation of ProxyApi and moves helper functions to a separate file #9756

[pigeon] Improves documentation of ProxyApi and moves helper functions to a separate file #9756

Uh oh!

Conversation

bparrishMines commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

bparrishMines Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

tarrinneal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[pigeon] Improves documentation of `ProxyApi` and moves helper functions to a separate file #9756

[pigeon] Improves documentation of `ProxyApi` and moves helper functions to a separate file #9756

bparrishMines commented Aug 5, 2025 •

edited

Loading